Skip to content

ss-1945 Changes to run Depictio with Gateway API#554

Open
j-awada wants to merge 8 commits into
developfrom
ss-1945/depictio-gateway-api
Open

ss-1945 Changes to run Depictio with Gateway API#554
j-awada wants to merge 8 commits into
developfrom
ss-1945/depictio-gateway-api

Conversation

@j-awada

@j-awada j-awada commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

Jira: https://scilifelab.atlassian.net/browse/SS-1945

Changes in the Depictio app model type to enable running it with Gateway API.

Relates to: depictio/depictio#882

TODO

  • Test changes on Serve dev
  • Update Depictio chart version in fixtures/apps_fixtures.json
  • Only merge this PR after Serve's v5.1.0-beta release

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have added or updated unit and end2end tests or a manual test case to complement my changes
  • I have ran unit and end2end tests
  • I have considered accessibility for UI changes and reviewed pre-commit/Pa11y results or documented a manual check
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts
  • In case your changes are large enough, did you deploy your changes to develop instance?

PR cheatsheet

  • PR -- pull request
  • Include jira ticket in the PR title (like SS-1234 Introduced machine learning ai driven framework for DDLS Fellows from EMBL)
  • To set the status of the pull request, use the built-in github feature to set the PR as Draft or Ready for review.
  • To indicate the type of change (such as bugfix or new feature), use a github pull request label.
  • If pr is not ready for review, set it draft. We agreed in the team, that if the PR in the draft state, no one will review it.
  • Remember, that you can trigger end2end tests manually

j-awada added 5 commits June 24, 2026 14:43
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
@j-awada j-awada self-assigned this Jun 26, 2026
@j-awada j-awada requested a review from a team as a code owner June 26, 2026 06:42
@j-awada j-awada requested review from hamzaimran08 and removed request for a team June 26, 2026 06:55

@hamzaimran08 hamzaimran08 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to do anything about k8s_values["backend"] and k8s_values["minio"] in apps/models/app_types/depictio.py as they seem to have separate ingresses?

@j-awada

j-awada commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Do you think we need to do anything about k8s_values["backend"] and k8s_values["minio"] in apps/models/app_types/depictio.py as they seem to have separate ingresses?

They do, however httproutes get created for them from depictio's chart here or was there anything else that was missing?

j-awada added 2 commits July 9, 2026 13:57
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants