ss-1945 Changes to run Depictio with Gateway API#554
Open
j-awada wants to merge 8 commits into
Open
Conversation
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
1 task
hamzaimran08
left a comment
Collaborator
There was a problem hiding this comment.
Do you think we need to do anything about k8s_values["backend"] and k8s_values["minio"] in apps/models/app_types/depictio.py as they seem to have separate ingresses?
Contributor
Author
They do, however httproutes get created for them from depictio's chart here or was there anything else that was missing? |
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira: https://scilifelab.atlassian.net/browse/SS-1945
Changes in the Depictio app model type to enable running it with Gateway API.
Relates to: depictio/depictio#882
TODO
fixtures/apps_fixtures.jsonChecklist
PR cheatsheet
SS-1234 Introduced machine learning ai driven framework for DDLS Fellows from EMBL)