Skip to content

ss-1974 Misc changes to fix the integration tests#559

Merged
j-awada merged 6 commits into
developfrom
ss-1974/fix-integration-test
Jun 30, 2026
Merged

ss-1974 Misc changes to fix the integration tests#559
j-awada merged 6 commits into
developfrom
ss-1974/fix-integration-test

Conversation

@j-awada

@j-awada j-awada commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

Jira: https://scilifelab.atlassian.net/browse/SS-1974

Fixing some integration tests before release v5.1.0, these include:

  • Change Public access modes to Link
  • Use shorter name and lastname for creator
  • Remove public app checks
  • Update "faulty Docker image" check
  • Use keyword lower case when comparing

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have added or updated unit and end2end tests or a manual test case to complement my changes
  • I have ran unit and end2end tests
  • I have considered accessibility for UI changes and reviewed pre-commit/Pa11y results or documented a manual check
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts
  • In case your changes are large enough, did you deploy your changes to develop instance?

PR cheatsheet

  • PR -- pull request
  • Include jira ticket in the PR title (like SS-1234 Introduced machine learning ai driven framework for DDLS Fellows from EMBL)
  • To set the status of the pull request, use the built-in github feature to set the PR as Draft or Ready for review.
  • To indicate the type of change (such as bugfix or new feature), use a github pull request label.
  • If pr is not ready for review, set it draft. We agreed in the team, that if the PR in the draft state, no one will review it.
  • Remember, that you can trigger end2end tests manually

j-awada added 2 commits June 30, 2026 11:14
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
@j-awada j-awada self-assigned this Jun 30, 2026
j-awada added 3 commits June 30, 2026 13:04
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
Signed-off-by: Jana Awada <jana.awada@scilifelab.uu.se>
@j-awada j-awada marked this pull request as ready for review June 30, 2026 11:54
@j-awada j-awada requested a review from a team as a code owner June 30, 2026 11:54

@hamzaimran08 hamzaimran08 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-awada j-awada merged commit 8e940cc into develop Jun 30, 2026
3 checks passed
@j-awada j-awada deleted the ss-1974/fix-integration-test branch June 30, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants