Implement pki_enrollment_accept client part. #11464
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirelightFlagboy
requested changes
Oct 29, 2025
AureliaDolo
force-pushed
the
aurelia/pki/accept
branch
5 times, most recently
from
fb5e6d3 to
b5aa7de
Compare
- load pki submit local enrollment
AureliaDolo
force-pushed
the
aurelia/pki/accept
branch
from
b5aa7de to
add5a9d
Compare
FirelightFlagboy
requested changes
Nov 5, 2025
Comment on lines
+91
to
+96
| let local_file = libparsec_platform_device_loader::get_default_local_pending_file( | ||
| &client.config().config_dir, | ||
| enrollment_id, | ||
| ); | ||
|
|
||
| let local_pending = load_pki_local_pending(local_file).await?; |
There was a problem hiding this comment.
issue (blocking): The accepter won't have access to the local pending save on the submitter filesystem.
The payload is obtain from pki_enroll_list and the value should likely be provided to the function
| } | ||
| } | ||
|
|
||
| pub async fn load_pki_local_pending( |
There was a problem hiding this comment.
issue (blocking): We want need to load a local pending.
Instead we would list all available pending request and at that point we won't need to re-read a request on the filesystem has we would have everything we need extracted from the first step (#11524)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11360