Skip to content

OpenBao protection support for device keys file #11530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

OpenBao protection support for device keys file #11530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
24f3689
Minor import correction in `cli/src/commands/device/change_authentica…
touilleMan Oct 15, 2025
342b6e5
Introduce `libparsec/crates/types/schema/local_device/device_file_ope…
touilleMan Oct 31, 2025
9d47fb4
Add OpenBao support to `libparsec_platform_device_loader`
touilleMan Nov 2, 2025
7ab7317
Correct libparsec/libparsec_client/libparsec_account with new `Remote…
touilleMan Nov 2, 2025
11e53a9
Add mocked OpenBao API routes to the server testbed
touilleMan Nov 3, 2025
46cecae
Add `libparsec_openbao` crate
touilleMan Nov 3, 2025
9d73a13
Minor correction in error message for AccountRegisterNewDeviceError/I…
touilleMan Nov 3, 2025
ae985cb
Add OpenBao support to `libparsec` main crate and bindings
touilleMan Nov 4, 2025
93dbad4
Replace `Internal` by more precise `BadServerResponse` in `libparsec_…
touilleMan Nov 4, 2025
605a968
Re-generate electron&web bindings
touilleMan Nov 4, 2025
6f4d96a
Bump testbed server to 3.5.3-a.0.dev.20396.d489997
touilleMan Nov 4, 2025
ff9fef5
Fix GUI with new `DeviceSaveStrategy::OpenBao` variant
touilleMan Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
TESTBED_SERVER: http://localhost:6777
services:
parsec-testbed-server:
image: ghcr.io/scille/parsec-cloud/parsec-testbed-server:3.4.1-a.0.dev.20299.a9f26d7
image: ghcr.io/scille/parsec-cloud/parsec-testbed-server:3.5.3-a.0.dev.20396.d489997
ports:
- 6777:6777
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-web.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
# https://github.com/Scille/parsec-cloud/pkgs/container/parsec-cloud%2Fparsec-testbed-server
services:
parsec-testbed-server:
image: ghcr.io/scille/parsec-cloud/parsec-testbed-server:3.4.1-a.0.dev.20299.a9f26d7
image: ghcr.io/scille/parsec-cloud/parsec-testbed-server:3.5.3-a.0.dev.20396.d489997
ports:
- 6777:6777
steps:
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
shard_total: [2]
services:
parsec-testbed-server:
image: ghcr.io/scille/parsec-cloud/parsec-testbed-server:3.4.1-a.0.dev.20299.a9f26d7
image: ghcr.io/scille/parsec-cloud/parsec-testbed-server:3.5.3-a.0.dev.20396.d489997
ports:
- 6777:6777
timeout-minutes: 20
Expand Down
15 changes: 15 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ members = [
"libparsec/crates/client",
"libparsec/crates/client_connection",
"libparsec/crates/crypto",
"libparsec/crates/openbao",
"libparsec/crates/platform_async",
"libparsec/crates/platform_device_loader",
"libparsec/crates/platform_ipc",
Expand Down Expand Up @@ -34,6 +35,7 @@ default-members = [
"libparsec/crates/client",
"libparsec/crates/client_connection",
"libparsec/crates/crypto",
"libparsec/crates/openbao",
"libparsec/crates/platform_async",
"libparsec/crates/platform_device_loader",
"libparsec/crates/platform_ipc",
Expand Down Expand Up @@ -94,6 +96,7 @@ libparsec_account = { path = "libparsec/crates/account", default-features = fals
libparsec_client = { path = "libparsec/crates/client", default-features = false }
libparsec_client_connection = { path = "libparsec/crates/client_connection", default-features = false }
libparsec_crypto = { path = "libparsec/crates/crypto", default-features = false }
libparsec_openbao = { path = "libparsec/crates/openbao", default-features = false }
libparsec_platform_async = { path = "libparsec/crates/platform_async", default-features = false }
libparsec_platform_device_loader = { path = "libparsec/crates/platform_device_loader", default-features = false }
libparsec_platform_http_proxy = { path = "libparsec/crates/platform_http_proxy", default-features = false }
Expand Down
39 changes: 39 additions & 0 deletions bindings/electron/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,10 @@ export interface AccountCreateRegistrationDeviceErrorRemoteOpaqueKeyFetchFailed
tag: "AccountCreateRegistrationDeviceErrorRemoteOpaqueKeyFetchFailed"
error: string
}
export interface AccountCreateRegistrationDeviceErrorRemoteOpaqueKeyFetchOffline {
tag: "AccountCreateRegistrationDeviceErrorRemoteOpaqueKeyFetchOffline"
error: string
}
export interface AccountCreateRegistrationDeviceErrorTimestampOutOfBallpark {
tag: "AccountCreateRegistrationDeviceErrorTimestampOutOfBallpark"
error: string
Expand All @@ -608,6 +612,7 @@ export type AccountCreateRegistrationDeviceError =
| AccountCreateRegistrationDeviceErrorNotAllowedByOrganizationVaultStrategy
| AccountCreateRegistrationDeviceErrorOffline
| AccountCreateRegistrationDeviceErrorRemoteOpaqueKeyFetchFailed
| AccountCreateRegistrationDeviceErrorRemoteOpaqueKeyFetchOffline
| AccountCreateRegistrationDeviceErrorTimestampOutOfBallpark


Expand Down Expand Up @@ -916,6 +921,10 @@ export interface AccountRegisterNewDeviceErrorRemoteOpaqueKeyUploadFailed {
tag: "AccountRegisterNewDeviceErrorRemoteOpaqueKeyUploadFailed"
error: string
}
export interface AccountRegisterNewDeviceErrorRemoteOpaqueKeyUploadOffline {
tag: "AccountRegisterNewDeviceErrorRemoteOpaqueKeyUploadOffline"
error: string
}
export interface AccountRegisterNewDeviceErrorStorageNotAvailable {
tag: "AccountRegisterNewDeviceErrorStorageNotAvailable"
error: string
Expand All @@ -935,6 +944,7 @@ export type AccountRegisterNewDeviceError =
| AccountRegisterNewDeviceErrorInvalidPath
| AccountRegisterNewDeviceErrorOffline
| AccountRegisterNewDeviceErrorRemoteOpaqueKeyUploadFailed
| AccountRegisterNewDeviceErrorRemoteOpaqueKeyUploadOffline
| AccountRegisterNewDeviceErrorStorageNotAvailable
| AccountRegisterNewDeviceErrorTimestampOutOfBallpark
| AccountRegisterNewDeviceErrorUnknownRegistrationDevice
Expand Down Expand Up @@ -1006,6 +1016,11 @@ export interface AvailableDeviceTypeAccountVault {
export interface AvailableDeviceTypeKeyring {
tag: "AvailableDeviceTypeKeyring"
}
export interface AvailableDeviceTypeOpenBao {
tag: "AvailableDeviceTypeOpenBao"
openbao_preferred_auth: string
openbao_entity_id: string
}
export interface AvailableDeviceTypePassword {
tag: "AvailableDeviceTypePassword"
}
Expand All @@ -1018,6 +1033,7 @@ export interface AvailableDeviceTypeSmartcard {
export type AvailableDeviceType =
| AvailableDeviceTypeAccountVault
| AvailableDeviceTypeKeyring
| AvailableDeviceTypeOpenBao
| AvailableDeviceTypePassword
| AvailableDeviceTypeRecovery
| AvailableDeviceTypeSmartcard
Expand Down Expand Up @@ -2241,6 +2257,14 @@ export interface DeviceAccessStrategyKeyring {
tag: "DeviceAccessStrategyKeyring"
key_file: string
}
export interface DeviceAccessStrategyOpenBao {
tag: "DeviceAccessStrategyOpenBao"
key_file: string
openbao_server_url: string
openbao_secret_mount_path: string
openbao_entity_id: string
openbao_auth_token: string
}
export interface DeviceAccessStrategyPassword {
tag: "DeviceAccessStrategyPassword"
password: string
Expand All @@ -2253,6 +2277,7 @@ export interface DeviceAccessStrategySmartcard {
export type DeviceAccessStrategy =
| DeviceAccessStrategyAccountVault
| DeviceAccessStrategyKeyring
| DeviceAccessStrategyOpenBao
| DeviceAccessStrategyPassword
| DeviceAccessStrategySmartcard

Expand All @@ -2265,6 +2290,14 @@ export interface DeviceSaveStrategyAccountVault {
export interface DeviceSaveStrategyKeyring {
tag: "DeviceSaveStrategyKeyring"
}
export interface DeviceSaveStrategyOpenBao {
tag: "DeviceSaveStrategyOpenBao"
openbao_server_url: string
openbao_secret_mount_path: string
openbao_entity_id: string
openbao_auth_token: string
openbao_preferred_auth: string
}
export interface DeviceSaveStrategyPassword {
tag: "DeviceSaveStrategyPassword"
password: string
Expand All @@ -2276,6 +2309,7 @@ export interface DeviceSaveStrategySmartcard {
export type DeviceSaveStrategy =
| DeviceSaveStrategyAccountVault
| DeviceSaveStrategyKeyring
| DeviceSaveStrategyOpenBao
| DeviceSaveStrategyPassword
| DeviceSaveStrategySmartcard

Expand Down Expand Up @@ -2440,6 +2474,10 @@ export interface ImportRecoveryDeviceErrorRemoteOpaqueKeyUploadFailed {
tag: "ImportRecoveryDeviceErrorRemoteOpaqueKeyUploadFailed"
error: string
}
export interface ImportRecoveryDeviceErrorRemoteOpaqueKeyUploadOffline {
tag: "ImportRecoveryDeviceErrorRemoteOpaqueKeyUploadOffline"
error: string
}
export interface ImportRecoveryDeviceErrorStopped {
tag: "ImportRecoveryDeviceErrorStopped"
error: string
Expand All @@ -2465,6 +2503,7 @@ export type ImportRecoveryDeviceError =
| ImportRecoveryDeviceErrorInvalidPath
| ImportRecoveryDeviceErrorOffline
| ImportRecoveryDeviceErrorRemoteOpaqueKeyUploadFailed
| ImportRecoveryDeviceErrorRemoteOpaqueKeyUploadOffline
| ImportRecoveryDeviceErrorStopped
| ImportRecoveryDeviceErrorStorageNotAvailable
| ImportRecoveryDeviceErrorTimestampOutOfBallpark
Expand Down
Loading
Loading