Skip to content

kanata: Update to version 1.11.0, fix autoupdate, add arm64 support#17831

Merged
z-Fng merged 4 commits into
ScoopInstaller:masterfrom
JalonWong:kanata
May 20, 2026
Merged

kanata: Update to version 1.11.0, fix autoupdate, add arm64 support#17831
z-Fng merged 4 commits into
ScoopInstaller:masterfrom
JalonWong:kanata

Conversation

@JalonWong

@JalonWong JalonWong commented May 19, 2026

Copy link
Copy Markdown
Contributor
  • Fix autoupdate.
  • Add shortcuts for the GUI executable files.
  • Merge kanata-cmd.
  • Add ARM64 architecture.

Close #15529

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates bucket/kanata.json to version 1.11.0. The Windows x64 artifact is changed from a single kanata.exe to windows-binaries-x64.zip with an updated SHA256; top-level bin is removed and replaced by architecture.64bit.bin and architecture.64bit.shortcuts entries. A full architecture.arm64 block (URL, hash, bin, shortcuts) is added. autoupdate.architecture.64bit.url now templates the x64 zip, and autoupdate.hash.url is added pointing to $baseurl/sha256sums.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description includes a linked issue reference (#15529), uses the conventional PR title format, and documents key changes including autoupdate fixes, GUI shortcuts, cmd merge, and ARM64 support.
Linked Issues check ✅ Passed The PR successfully implements all requirements from #15529: GUI executables are now included via shortcuts arrays, cmd variants are merged, ARM64 architecture is added, and autoupdate functionality is fixed with proper hash sources.
Out of Scope Changes check ✅ Passed All changes in bucket/kanata.json are directly aligned with the linked issue objectives: version bump to 1.11.0, autoupdate fix with hash URL, GUI shortcuts addition, cmd merge, and ARM64 architecture support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The pull request title accurately summarizes the three main changes: version update to 1.11.0, autoupdate fix, and ARM64 support addition.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JalonWong

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

kanata

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@JalonWong

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

kanata

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@JalonWong

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

kanata

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng

z-Fng commented May 20, 2026

Copy link
Copy Markdown
Contributor

/verify

@z-Fng z-Fng changed the title kanata@1.11.0: fix autoupdate kanata: Update to version 1.11.0, fix autoupdate May 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

kanata

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng z-Fng changed the title kanata: Update to version 1.11.0, fix autoupdate kanata: Update to version 1.11.0, fix autoupdate, add arm64 support May 20, 2026

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/kanata.json (1)

2-73: Run local manifest validation for both architectures before merge.

Use:

  • .\bin\checkver.ps1 -App kanata -f
  • .\bin\formatjson.ps1 -App kanata
  • scoop install .\bucket\kanata.json -a 64bit
  • scoop install .\bucket\kanata.json -a arm64

Reference:

As per coding guidelines, Scoop manifest changes should be validated with checkver/format/install flows for each supported architecture.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/kanata.json` around lines 2 - 73, Run the local manifest validation
and installation flows for both architectures for the kanata manifest: execute
.\bin\checkver.ps1 -App kanata -f and .\bin\formatjson.ps1 -App kanata, then
test install with scoop install .\bucket\kanata.json -a 64bit and scoop install
.\bucket\kanata.json -a arm64; fix any errors reported (version/hash mismatches,
malformed JSON, incorrect "bin"/"shortcuts" entries) and ensure the autoupdate
"url" patterns and "hash" lookup ($baseurl/sha256sums) validate correctly for
both 64bit and arm64 sections before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/kanata.json`:
- Around line 70-71: The autoupdate hash URL currently points to a shared
checksum file without a selector which can return ambiguous lines for multi-arch
assets; update the manifest's autoupdate hash block by adding a "find":
"$basename" entry alongside the existing "url" (i.e., modify the autoupdate.hash
object to include "find": "$basename") so checksum extraction matches the
architecture-specific asset basename when running updates.

---

Nitpick comments:
In `@bucket/kanata.json`:
- Around line 2-73: Run the local manifest validation and installation flows for
both architectures for the kanata manifest: execute .\bin\checkver.ps1 -App
kanata -f and .\bin\formatjson.ps1 -App kanata, then test install with scoop
install .\bucket\kanata.json -a 64bit and scoop install .\bucket\kanata.json -a
arm64; fix any errors reported (version/hash mismatches, malformed JSON,
incorrect "bin"/"shortcuts" entries) and ensure the autoupdate "url" patterns
and "hash" lookup ($baseurl/sha256sums) validate correctly for both 64bit and
arm64 sections before merging.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3540934c-3c6e-4a56-8294-72cd9f8f717e

📥 Commits

Reviewing files that changed from the base of the PR and between a3313f5 and f94e36f.

📒 Files selected for processing (1)
  • bucket/kanata.json

Comment thread bucket/kanata.json
@z-Fng z-Fng merged commit e9cb9ac into ScoopInstaller:master May 20, 2026
3 checks passed
z-Fng added a commit that referenced this pull request May 20, 2026
* The kanata package now includes both the GUI and TUI, so there
  is no need for a separate kanata-cmd package.
* Relates to #15529, #17831.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: kanata: Add gui binaries

2 participants