kanata: Update to version 1.11.0, fix autoupdate, add arm64 support#17831
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates bucket/kanata.json to version 1.11.0. The Windows x64 artifact is changed from a single kanata.exe to windows-binaries-x64.zip with an updated SHA256; top-level bin is removed and replaced by architecture.64bit.bin and architecture.64bit.shortcuts entries. A full architecture.arm64 block (URL, hash, bin, shortcuts) is added. autoupdate.architecture.64bit.url now templates the x64 zip, and autoupdate.hash.url is added pointing to $baseurl/sha256sums. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
All changes look good. Wait for review from human collaborators. kanata
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. kanata
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. kanata
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. kanata
|
z-Fng
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/kanata.json (1)
2-73: Run local manifest validation for both architectures before merge.Use:
.\bin\checkver.ps1 -App kanata -f.\bin\formatjson.ps1 -App kanatascoop install .\bucket\kanata.json -a 64bitscoop install .\bucket\kanata.json -a arm64Reference:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, Scoop manifest changes should be validated with checkver/format/install flows for each supported architecture.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/kanata.json` around lines 2 - 73, Run the local manifest validation and installation flows for both architectures for the kanata manifest: execute .\bin\checkver.ps1 -App kanata -f and .\bin\formatjson.ps1 -App kanata, then test install with scoop install .\bucket\kanata.json -a 64bit and scoop install .\bucket\kanata.json -a arm64; fix any errors reported (version/hash mismatches, malformed JSON, incorrect "bin"/"shortcuts" entries) and ensure the autoupdate "url" patterns and "hash" lookup ($baseurl/sha256sums) validate correctly for both 64bit and arm64 sections before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/kanata.json`:
- Around line 70-71: The autoupdate hash URL currently points to a shared
checksum file without a selector which can return ambiguous lines for multi-arch
assets; update the manifest's autoupdate hash block by adding a "find":
"$basename" entry alongside the existing "url" (i.e., modify the autoupdate.hash
object to include "find": "$basename") so checksum extraction matches the
architecture-specific asset basename when running updates.
---
Nitpick comments:
In `@bucket/kanata.json`:
- Around line 2-73: Run the local manifest validation and installation flows for
both architectures for the kanata manifest: execute .\bin\checkver.ps1 -App
kanata -f and .\bin\formatjson.ps1 -App kanata, then test install with scoop
install .\bucket\kanata.json -a 64bit and scoop install .\bucket\kanata.json -a
arm64; fix any errors reported (version/hash mismatches, malformed JSON,
incorrect "bin"/"shortcuts" entries) and ensure the autoupdate "url" patterns
and "hash" lookup ($baseurl/sha256sums) validate correctly for both 64bit and
arm64 sections before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3540934c-3c6e-4a56-8294-72cd9f8f717e
📒 Files selected for processing (1)
bucket/kanata.json
Close #15529
<manifest-name[@version]|chore>: <general summary of the pull request>