kanata-cmd: Update to version 1.11.0, fix autoupdate#17832
Conversation
📝 WalkthroughWalkthroughThis PR updates the Kanata command-line tool manifest from version 1.9.0 to 1.11.0. The version field in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
All changes look good. Wait for review from human collaborators. kanata-cmd
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/kanata-cmd.json (1)
30-36: ⚡ Quick winAdd
binandshortcutsto the autoupdate block for consistency with architecture.64bit.The
autoupdateblock currently only specifies the URL but omits thebinandshortcutsdefinitions. While executable names in v1.11.0 appear stable and match the manifest, including these definitions in the autoupdate block ensures they remain synchronized during future automated updates.Update the autoupdate block from:
"autoupdate": { "architecture": { "64bit": { "url": "https://github.com/jtroo/kanata/releases/download/v$version/windows-binaries-x64.zip" } } }To:
"autoupdate": { "architecture": { "64bit": { "url": "https://github.com/jtroo/kanata/releases/download/v$version/windows-binaries-x64.zip", "bin": [ [ "kanata_windows_tty_winIOv2_cmd_allowed_x64.exe", "Kanata-cmd" ] ], "shortcuts": [ [ "kanata_windows_gui_winIOv2_cmd_allowed_x64.exe", "Kanata-cmd" ] ] } } }This ensures that if executable names ever change in future releases, they will be properly updated during autoupdate runs rather than causing broken shortcuts or bin entries.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/kanata-cmd.json` around lines 30 - 36, The autoupdate block for the 64bit architecture is missing the "bin" and "shortcuts" entries; update the autoupdate -> architecture -> 64bit object to include a "bin" array and a "shortcuts" array that mirror the manifest executable names (e.g. add a bin entry mapping "kanata_windows_tty_winIOv2_cmd_allowed_x64.exe" to "Kanata-cmd" and a shortcuts entry mapping "kanata_windows_gui_winIOv2_cmd_allowed_x64.exe" to "Kanata-cmd") so automated updates keep the executable and shortcut names in sync with the manifest.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/kanata-cmd.json`:
- Around line 30-36: The autoupdate block for the 64bit architecture is missing
the "bin" and "shortcuts" entries; update the autoupdate -> architecture ->
64bit object to include a "bin" array and a "shortcuts" array that mirror the
manifest executable names (e.g. add a bin entry mapping
"kanata_windows_tty_winIOv2_cmd_allowed_x64.exe" to "Kanata-cmd" and a shortcuts
entry mapping "kanata_windows_gui_winIOv2_cmd_allowed_x64.exe" to "Kanata-cmd")
so automated updates keep the executable and shortcut names in sync with the
manifest.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5b58352f-bf1c-4239-8dcc-8675909203bb
📒 Files selected for processing (1)
bucket/kanata-cmd.json
#17831
<manifest-name[@version]|chore>: <general summary of the pull request>