Skip to content

kanata-cmd: Update to version 1.11.0, fix autoupdate#17832

Closed
JalonWong wants to merge 1 commit into
ScoopInstaller:masterfrom
JalonWong:kanata-cmd
Closed

kanata-cmd: Update to version 1.11.0, fix autoupdate#17832
JalonWong wants to merge 1 commit into
ScoopInstaller:masterfrom
JalonWong:kanata-cmd

Conversation

@JalonWong

@JalonWong JalonWong commented May 19, 2026

Copy link
Copy Markdown
Contributor

#17831

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the Kanata command-line tool manifest from version 1.9.0 to 1.11.0. The version field in bucket/kanata-cmd.json was incremented, and the Windows x64 release metadata was correspondingly updated with a new download URL, hash value, executable filename (kanata_windows_tty_winIOv2_cmd_allowed_x64.exe), and autoupdate URL template that references the windows-binaries-x64.zip archive.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'kanata-cmd@1.11.0: fix autoupdate' directly corresponds to the main change: updating the kanata-cmd manifest to version 1.11.0 and fixing the autoupdate configuration.
Description check ✅ Passed The pull request description includes both required checklist items: conventional PR title format and confirmation of reading the Contributing Guide.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JalonWong

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

kanata-cmd

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/kanata-cmd.json (1)

30-36: ⚡ Quick win

Add bin and shortcuts to the autoupdate block for consistency with architecture.64bit.

The autoupdate block currently only specifies the URL but omits the bin and shortcuts definitions. While executable names in v1.11.0 appear stable and match the manifest, including these definitions in the autoupdate block ensures they remain synchronized during future automated updates.

Update the autoupdate block from:

"autoupdate": {
    "architecture": {
        "64bit": {
            "url": "https://github.com/jtroo/kanata/releases/download/v$version/windows-binaries-x64.zip"
        }
    }
}

To:

"autoupdate": {
    "architecture": {
        "64bit": {
            "url": "https://github.com/jtroo/kanata/releases/download/v$version/windows-binaries-x64.zip",
            "bin": [
                [
                    "kanata_windows_tty_winIOv2_cmd_allowed_x64.exe",
                    "Kanata-cmd"
                ]
            ],
            "shortcuts": [
                [
                    "kanata_windows_gui_winIOv2_cmd_allowed_x64.exe",
                    "Kanata-cmd"
                ]
            ]
        }
    }
}

This ensures that if executable names ever change in future releases, they will be properly updated during autoupdate runs rather than causing broken shortcuts or bin entries.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/kanata-cmd.json` around lines 30 - 36, The autoupdate block for the
64bit architecture is missing the "bin" and "shortcuts" entries; update the
autoupdate -> architecture -> 64bit object to include a "bin" array and a
"shortcuts" array that mirror the manifest executable names (e.g. add a bin
entry mapping "kanata_windows_tty_winIOv2_cmd_allowed_x64.exe" to "Kanata-cmd"
and a shortcuts entry mapping "kanata_windows_gui_winIOv2_cmd_allowed_x64.exe"
to "Kanata-cmd") so automated updates keep the executable and shortcut names in
sync with the manifest.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/kanata-cmd.json`:
- Around line 30-36: The autoupdate block for the 64bit architecture is missing
the "bin" and "shortcuts" entries; update the autoupdate -> architecture ->
64bit object to include a "bin" array and a "shortcuts" array that mirror the
manifest executable names (e.g. add a bin entry mapping
"kanata_windows_tty_winIOv2_cmd_allowed_x64.exe" to "Kanata-cmd" and a shortcuts
entry mapping "kanata_windows_gui_winIOv2_cmd_allowed_x64.exe" to "Kanata-cmd")
so automated updates keep the executable and shortcut names in sync with the
manifest.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5b58352f-bf1c-4239-8dcc-8675909203bb

📥 Commits

Reviewing files that changed from the base of the PR and between 6ebbef7 and 0c2507c.

📒 Files selected for processing (1)
  • bucket/kanata-cmd.json

@JalonWong JalonWong closed this May 19, 2026
@JalonWong JalonWong deleted the kanata-cmd branch May 19, 2026 16:31
@z-Fng z-Fng changed the title kanata-cmd@1.11.0: fix autoupdate kanata-cmd: Update to version 1.11.0, fix autoupdate May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants