Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sshs: Add version 4.5.1 #14145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

sshs: Add version 4.5.1 #14145

wants to merge 3 commits into from
+31 −0

Conversation

xd-mau5
Copy link

@xd-mau5 xd-mau5 commented Oct 4, 2024

Closes #13003

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

All changes look good.

Wait for review from human collaborators.

sshs

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

aliesbelik
aliesbelik requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Inline renaming via #/ is more laconic and makes pre_install unnecessary.
  • Default regex for github link in checkver is enough.

bucket/sshs.json Outdated Show resolved Hide resolved
bucket/sshs.json Outdated Show resolved Hide resolved
bucket/sshs.json Outdated Show resolved Hide resolved
bucket/sshs.json Outdated Show resolved Hide resolved
bucket/sshs.json Outdated Show resolved Hide resolved
bucket/sshs.json Outdated Show resolved Hide resolved
@aliesbelik
Copy link
Collaborator

Looks like could be promoted into the Main bucket instead, since fits the Main criteria.

@xd-mau5
Copy link
Author

xd-mau5 commented Oct 4, 2024

Should i make the pull request in Main then?

@aliesbelik
Copy link
Collaborator

Should i make the pull request in Main then?

I'm not maintainer of Main so I couldn't transfer your request and pr, but if you are interested in promoting requested tool into Main instead Extras, I suppose this would be a more suitable place.
Otherwise could be merged into Extras, with the requested changes.

@xd-mau5
Copy link
Author

xd-mau5 commented Oct 4, 2024

/review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliesbelik aliesbelik aliesbelik requested changes

Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request]: sshs
2 participants
@xd-mau5 @aliesbelik