chore: Relocate process termination logic to uninstaller script for safety

bucket/apifox.json

@@ -21,10 +21,12 @@
         ]
     ],
     "persist": "UserData",
-    "pre_uninstall": [
-        "Stop-Process -Name 'ApifoxAppAgent' -Force -ErrorAction SilentlyContinue",
-        "Start-Sleep -Milliseconds 1500"
-    ],
+    "uninstaller": {
+        "script": [
+            "Stop-Process -Name 'ApifoxAppAgent' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": {
         "url": "https://docs.apifox.com/changelog.md",
         "regex": "## ([\\d.]+)(?=\\s)"

bucket/attribute-changer.json

@@ -53,16 +53,6 @@
             "Set-Content \"$dir\\change-ac-language.ps1\" $value -Encoding 'utf8' -Force"
         ]
     },
-    "bin": [
-        "acmain.exe",
-        "change-ac-language.ps1"
-    ],
-    "shortcuts": [
-        [
-            "acmain.exe",
-            "Attribute Changer"
-        ]
-    ],
     "post_install": [
         "$documents = (Get-ChildItem $dir -Filter '*.pdf').Length; $subtract = $documents - 5",
         "Copy-Item \"$dir\\template.ini\" \"$dir\\messages,$documents.ini\"; Copy-Item \"$dir\\template.ini\" \"$dir\\messages.ini\"; Copy-Item \"$dir\\ac,$(($documents - $subtract) - 2).pdf\" \"$dir\\ac.pdf\"",
@@ -73,11 +63,24 @@
         "}",
         "Copy-Item \"$dir\\ac.pdf\" \"$dir\\ac,$documents.pdf\""
     ],
-    "pre_uninstall": [
-        "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
-        "Start-Process 'regsvr32' -ArgumentList @('/u', \"$dir\\acshell.dll\", '/s') -Verb 'RunAs' -Wait; Stop-Process -Name 'explorer' -Force",
-        "Stop-Process -Name 'dllhost' -ErrorAction 'SilentlyContinue' -Force; Start-Sleep -Seconds 2"
+    "bin": [
+        "acmain.exe",
+        "change-ac-language.ps1"
+    ],
+    "shortcuts": [
+        [
+            "acmain.exe",
+            "Attribute Changer"
+        ]
     ],
+    "pre_uninstall": "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
+    "uninstaller": {
+        "script": [
+            "Start-Process 'regsvr32' -ArgumentList @('/u', \"$dir\\acshell.dll\", '/s') -Wait",
+            "Stop-Process -Name 'dllhost', 'explorer' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": "(?:v|V)ersion\\s([\\w.]+)",
     "autoupdate": {
         "url": "https://www.petges.lu/pubfiles/ac-$underscoreVersion.exe",

bucket/audioswitcher.json

@@ -5,14 +5,19 @@
     "license": "MS-PL",
     "url": "https://github.com/xenolightning/AudioSwitcher_v1/releases/download/1.8.0.142/AudioSwitcher.zip",
     "hash": "e675b85a7c8465e02b58148f8d98b4adab78c3a7423160ca78d1237d8469ace4",
-    "pre_install": "Stop-Process -Name AudioSwitcher -Verbose -ErrorAction Ignore",
     "bin": "AudioSwitcher.exe",
     "shortcuts": [
         [
             "AudioSwitcher.exe",
             "Audio Switcher"
         ]
     ],
+    "uninstaller": {
+        "script": [
+            "Stop-Process -Name 'AudioSwitcher' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": {
         "github": "https://github.com/xenolightning/AudioSwitcher_v1"
     },

bucket/buttercup.json

@@ -9,13 +9,18 @@
             "hash": "00725c3fe000691bd69e2f675ba8312428b6751ff7a4a43224c6468f818e375a"
         }
     },
-    "pre_uninstall": "Stop-Process -Name 'Buttercup' -ErrorAction SilentlyContinue",
     "shortcuts": [
         [
             "Buttercup.exe",
             "Buttercup"
         ]
     ],
+    "uninstaller": {
+        "script": [
+            "Stop-Process -Name 'Buttercup' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": {
         "github": "https://github.com/buttercup/buttercup-desktop/"
     },

bucket/coretemp.json

@@ -6,7 +6,11 @@
         "identifier": "Freeware",
         "url": "https://www.alcpu.com/CoreTemp/terms.html"
     },
-    "notes": "Download language packs by running: \"$dir\\download-language-packs.ps1\" (\"powershell \"$dir\\download-language-packs.ps1\"\" under cmd)",
+    "notes": [
+        "Download the language packs by running either of the following commands:",
+        "- \"$dir\\download-language-packs.ps1\"",
+        "- powershell \"$dir\\download-language-packs.ps1\" (when using Command Prompt)"
+    ],
     "architecture": {
         "64bit": {
             "url": "https://www.alcpu.com/CoreTemp/CoreTemp64.zip",
@@ -18,18 +22,10 @@
         }
     },
     "pre_install": [
-        "Copy-Item \"$bucketsdir\\extras\\scripts\\coretemp\\download-language-packs.ps1\" \"$dir\\\" | Out-Null",
-        "if (Test-Path \"$persist_dir\\CoreTemp.ini\") { Copy-Item \"$persist_dir\\CoreTemp.ini\" \"$dir\\\" | Out-Null }"
+        "Copy-Item \"$bucketsdir\\$bucket\\scripts\\$app\\download-language-packs.ps1\" $dir",
+        "# Hard links are not applicable here because the application creates a new file instead of modifying the existing one in place.",
+        "if (Test-Path -Path \"$persist_dir\\CoreTemp.ini\" -PathType Leaf) { Copy-Item \"$persist_dir\\CoreTemp.ini\" $dir -Force }"
     ],
-    "pre_uninstall": "Stop-Process -Name 'Core Temp' -ErrorAction SilentlyContinue",
-    "uninstaller": {
-        "script": [
-            "if (Test-Path \"$dir\\CoreTemp.ini\") {",
-            "    ensure \"$persist_dir\" | Out-Null",
-            "    Copy-Item \"$dir\\CoreTemp.ini\" \"$persist_dir\\\" | Out-Null",
-            "}"
-        ]
-    },
     "shortcuts": [
         [
             "Core Temp.exe",
@@ -40,6 +36,16 @@
         "languages",
         "plugins"
     ],
+    "pre_uninstall": [
+        "# Hard links are not applicable here because the application creates a new file instead of modifying the existing one in place.",
+        "if (Test-Path -Path \"$dir\\CoreTemp.ini\" -PathType Leaf) { Copy-Item \"$dir\\CoreTemp.ini\" $persist_dir -Force }"
+    ],
+    "uninstaller": {
+        "script": [
+            "Stop-Process -Name 'Core Temp' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": {
         "url": "https://www.alcpu.com/CoreTemp/history.html",
         "regex": "Version ([\\d.]+)"

bucket/fastcopy.json

@@ -6,10 +6,6 @@
         "identifier": "Freeware",
         "url": "https://fastcopy.jp/help/fastcopy_eng.htm#license"
     },
-    "notes": [
-        "If an error occurs when updating or uninstalling, execute the following command then retry:",
-        "`Stop-Process -Name 'explorer'`"
-    ],
     "url": "https://fastcopy.jp/archive/FastCopy5.11.2_installer.exe",
     "hash": "70b273dd08c15d40fac59a217b93be195bacfa47acabd031463a6df800d29fea",
     "pre_install": [
@@ -34,9 +30,15 @@
     ],
     "pre_uninstall": [
         "ensure \"$persist_dir\\Log\" | Out-Null",
-        "Copy-Item \"$dir\\FastCopy.log\", \"$dir\\FastCopy2.ini\", \"$dir\\Log\" -Destination \"$persist_dir\" -Force -Recurse -ErrorAction SilentlyContinue",
-        "Start-Process \"$dir\\setup.exe\" -Args @('/SILENT', '/r') -Wait"
+        "Copy-Item \"$dir\\FastCopy.log\", \"$dir\\FastCopy2.ini\", \"$dir\\Log\" -Destination \"$persist_dir\" -Force -Recurse -ErrorAction SilentlyContinue"
     ],
+    "uninstaller": {
+        "script": [
+            "Start-Process \"$dir\\setup.exe\" -Args @('/SILENT', '/r') -Wait",
+            "Stop-Process -Name 'explorer' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": "Download v([\\d.]+)",
     "autoupdate": {
         "url": "https://fastcopy.jp/archive/FastCopy$version_installer.exe"

bucket/folder-marker.json

@@ -18,17 +18,6 @@
         "    Invoke-ExternalCommand regsvr32 -ArgumentList @(\"$dir\\ShellExt64.dll\", '/s') -RunAs | Out-Null",
         "}"
     ],
-    "pre_uninstall": [
-        "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
-        "Invoke-ExternalCommand regsvr32 -ArgumentList @('/u', \"$dir\\FMADM.dll\", '/s') -RunAs | Out-Null",
-        "Invoke-ExternalCommand regsvr32 -ArgumentList @('/u', \"$dir\\ShellExt.dll\", '/s') -RunAs | Out-Null",
-        "if ($architecture -eq '64bit') {",
-        "    Invoke-ExternalCommand regsvr32 -ArgumentList @('/u', \"$dir\\ShellExt64.dll\", '/s') -RunAs | Out-Null",
-        "}",
-        "# Restart explorer so that ShellExt(-64).dll can be removed",
-        "Stop-Process -Name 'explorer'; Start-Sleep -Seconds 2",
-        "if (!(Get-Process -Name 'explorer' -ErrorAction SilentlyContinue)) { Start-Process 'explorer' }"
-    ],
     "env_set": {
         "FOLDER_MARKER_DIR": "$dir"
     },
@@ -38,6 +27,19 @@
             "Folder Marker"
         ]
     ],
+    "pre_uninstall": "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
+    "uninstaller": {
+        "script": [
+            "Invoke-ExternalCommand regsvr32 -ArgumentList @('/u', \"$dir\\FMADM.dll\", '/s') -RunAs | Out-Null",
+            "Invoke-ExternalCommand regsvr32 -ArgumentList @('/u', \"$dir\\ShellExt.dll\", '/s') -RunAs | Out-Null",
+            "if ($architecture -eq '64bit') {",
+            "    Invoke-ExternalCommand regsvr32 -ArgumentList @('/u', \"$dir\\ShellExt64.dll\", '/s') -RunAs | Out-Null",
+            "}",
+            "# Restart explorer so that ShellExt(-64).dll can be removed",
+            "Stop-Process -Name 'explorer' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": {
         "url": "https://foldermarker.com/en/download/",
         "regex": "Version\\: ([\\d.]+)</p>"

bucket/iconview.json

@@ -7,32 +7,35 @@
     "architecture": {
         "32bit": {
             "url": "https://www.botproductions.com/iconview/download/IconViewer3.02-Setup-x86.exe#/dl.7z",
-            "hash": "2EB365EA3E2F20848206B0B1835C58CC71E2ACA1323A19319896B3C8E3BF3956",
+            "hash": "2eb365ea3e2f20848206b0b1835c58cc71e2aca1323a19319896b3c8e3bf3956",
             "pre_install": "Remove-Item \"$dir\\Setup.exe\""
         },
         "64bit": {
             "url": "https://www.botproductions.com/iconview/download/IconViewer3.02-Setup-x64.exe#/dl.7z",
-            "hash": "3BE3664CFAC0B9270DA161C2C4C323499B4FE40A8E68A2D34CD4425B12EF223F",
+            "hash": "3be3664cfac0b9270da161c2c4c323499b4fe40a8e68a2d34cd4425b12ef223f",
             "pre_install": "Remove-Item \"$dir\\Setup.exe\", \"$dir\\x86\" -Recurse"
         }
     },
     "installer": {
         "script": [
             "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
-            "Start-Process 'regsvr32' -Wait -Verb 'RunAs' -ArgumentList @(\"$dir\\iconview.dll\", '/s'); Start-Sleep -Seconds 2"
+            "Start-Process 'regsvr32' -ArgumentList @(\"$dir\\iconview.dll\", '/s') -Wait; Start-Sleep -Seconds 2"
         ]
     },
-    "pre_uninstall": [
-        "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
-        "Start-Process 'regsvr32' -Wait -Verb 'RunAs' -ArgumentList @('/u', \"$dir\\iconview.dll\", '/s')",
-        "Stop-Process -Name 'explorer' -Force; Start-Sleep -Seconds 3;"
-    ],
     "shortcuts": [
         [
             "iconview.chm",
             "IconViewer Help"
         ]
     ],
+    "pre_uninstall": "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
+    "uninstaller": {
+        "script": [
+            "Start-Process 'regsvr32' -ArgumentList @('/u', \"$dir\\iconview.dll\", '/s') -Wait",
+            "Stop-Process -Name 'explorer' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": {
         "url": "https://www.botproductions.com/iconview/download.html",
         "regex": "IconViewer\\s([\\d.]+)"

bucket/jackett.json

@@ -6,17 +6,20 @@
     "url": "https://github.com/Jackett/Jackett/releases/download/v0.24.957/Jackett.Binaries.Windows.zip",
     "hash": "15aeda69e6da475dedaaa8d78b8e873d73f2d85ae5a419b37bd7a72ba02135c2",
     "extract_dir": "Jackett",
-    "pre_uninstall": [
-        "'JacketTray', 'JacketConsole', 'JacketService' | ForEach-Object {",
-        "    Stop-Process -Name $_ -ErrorAction SilentlyContinue",
-        "}"
-    ],
     "shortcuts": [
         [
             "JackettTray.exe",
             "Jackett"
         ]
     ],
+    "uninstaller": {
+        "script": [
+            "'JackettTray', 'JackettConsole', 'JackettService' | ForEach-Object {",
+            "    Stop-Process -Name $_ -Force -ErrorAction SilentlyContinue",
+            "}",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": "github",
     "autoupdate": {
         "url": "https://github.com/Jackett/Jackett/releases/download/v$version/Jackett.Binaries.Windows.zip"

bucket/mellowplayer.json

@@ -18,11 +18,16 @@
         }
     },
     "pre_install": "Expand-InnoArchive \"$dir\\MellowPlayer_Setup.exe\" \"$dir\" -Removal | Out-Null",
-    "pre_uninstall": "Stop-Process -Name 'MellowPlayer' -ErrorAction SilentlyContinue",
     "shortcuts": [
         [
             "MellowPlayer.exe",
             "MellowPlayer"
         ]
-    ]
+    ],
+    "uninstaller": {
+        "script": [
+            "Stop-Process -Name 'MellowPlayer' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    }
 }

bucket/mobaxterm.json

@@ -39,11 +39,14 @@
         "    if (Test-Path -Path \"$dir\\$_\" -PathType Leaf) {",
         "        Copy-Item -Path \"$dir\\$_\" -Destination $persist_dir -Force",
         "    }",
-        "}",
-        "# Ensure background X server process is terminated to prevent resource lock.",
-        "Stop-Process -Name 'XWin_MobaX' -Force -ErrorAction SilentlyContinue",
-        "Start-Sleep -Milliseconds 1500"
+        "}"
     ],
+    "uninstaller": {
+        "script": [
+            "Stop-Process -Name 'XWin_MobaX' -Force -ErrorAction SilentlyContinue",
+            "Start-Sleep -Milliseconds 1500"
+        ]
+    },
     "checkver": {
         "url": "https://mobaxterm.mobatek.net/download-home-edition.html",
         "regex": "mobatek.net/(?<build>[^/]+)/MobaXterm_Portable_v([\\d.]+)\\.zip"

bucket/mp3tag.json

@@ -54,14 +54,18 @@
         "data",
         "mp3tag.cfg"
     ],
-    "pre_uninstall": [
-        "Copy-Item \"$dir\\export\\*\" \"$persist_dir\\export\" -Recurse -ErrorAction SilentlyContinue",
-        "if (Test-Path 'HKLM:\\SOFTWARE\\Classes\\Directory\\shellex\\ContextMenuHandlers\\Mp3tagShell\\') {",
-        "    if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
-        "    Start-Process 'regsvr32' -Wait -Verb RunAs -ArgumentList @('/u', \"$dir\\Mp3tagShell32.dll\", '/s')",
-        "    Start-Process 'regsvr32' -Wait -Verb RunAs -ArgumentList @('/u', \"$dir\\Mp3tagShell.dll\", '/s')",
-        "}"
-    ],
+    "pre_uninstall": "Copy-Item \"$dir\\export\\*\" \"$persist_dir\\export\" -Recurse -ErrorAction SilentlyContinue",
+    "uninstaller": {
+        "script": [
+            "if (Test-Path -Path 'HKLM:\\SOFTWARE\\Classes\\Directory\\shellex\\ContextMenuHandlers\\Mp3tagShell') {",
+            "    if (-not (is_admin)) { abort \"`n[ERROR]  $app requires admin rights to $cmd.\" }",
+            "    Start-Process 'regsvr32' -ArgumentList @('/u', \"$dir\\Mp3tagShell.dll\", '/s') -Wait",
+            "    Start-Process 'regsvr32' -ArgumentList @('/u', \"$dir\\Mp3tagShell32.dll\", '/s') -Wait",
+            "    Stop-Process -Name 'explorer' -Force -ErrorAction SilentlyContinue",
+            "    Start-Sleep -Milliseconds 1500",
+            "}"
+        ]
+    },
     "checkver": {
         "url": "https://www.mp3tag.de/en/download.html",
         "regex": "(?i)<h\\d>Mp3tag\\s+v(?<version>[\\d.]+[a-z]{0,1})</h\\d>"

bucket/openvpn.json

@@ -25,6 +25,7 @@
         }
     },
     "pre_install": [
+        "ensure $persist_dir | Out-Null",
         "if ([Environment]::OSVersion.Version.Major -lt 10) { error 'Windows 10 is required since version 2.4.8. Use \"versions/openvpn-w7\" instead'; break }",
         "if (-not (is_admin)) { error 'Administrator privileges are needed for installation'; break }",
         "Invoke-ExternalCommand msiexec -ArgumentList @('/i', \"`\"$dir\\setup.msi_`\"\", \"PRODUCTDIR=`\"$dir`\"\", 'ADDLOCAL=OpenVPN.GUI,OpenVPN.Service,OpenVPN.Documentation,OpenVPN.SampleCfg,OpenSSL,EasyRSA,OpenVPN,OpenVPN.GUI.OnLogon,Drivers.TAPWindows6,Drivers,Drivers.Wintun', '/passive') -RunAs | Out-Null",
@@ -38,26 +39,25 @@
         "    }",
         "}",
         "if (-not (Test-Path -Path \"$persist_dir\\config\")) {",
-        "    Copy-Item -Path \"$dir\\sample-config\\*\" -Destination \"$dir\\config\\\" -Force -Recurse",
+        "    Copy-Item -Path \"$dir\\sample-config\\*\" -Destination \"$dir\\config\" -Force -Recurse",
         "}"
     ],
+    "bin": "bin\\openvpn.exe",
     "pre_uninstall": [
         "# Persist manually because the uninstaller deletes the 'config' and 'config-auto' folder",
         "'config', 'config-auto' | ForEach-Object {",
         "    if (Test-Path -Path \"$dir\\$_\") {",
-        "        ensure $persist_dir | Out-Null",
         "        Copy-Item -Path \"$dir\\$_\" -Destination $persist_dir -Force -Recurse",
         "    }",
-        "}",
-        "Stop-Process -Name 'openvpn*' -Force -ErrorAction SilentlyContinue"
+        "}"
     ],
     "uninstaller": {
         "script": [
             "if (-not (is_admin)) { error 'Admin privileges are needed.'; break }",
-            "Invoke-ExternalCommand msiexec -ArgumentList ('/x', \"`\"$dir\\setup.msi_`\"\", '/passive') -RunAs | Out-Null"
+            "Stop-Process -Name 'openvpn*' -Force -ErrorAction SilentlyContinue; Start-Sleep -Milliseconds 1500",
+            "Invoke-ExternalCommand msiexec -ArgumentList ('/x', \"`\"$dir\\setup.msi_`\"\", '/passive') | Out-Null"
         ]
     },
-    "bin": "bin\\openvpn.exe",
     "checkver": {
         "url": "https://openvpn.net/index.php/open-source/downloads.html",
         "regex": "OpenVPN-([\\d.]+-I[\\d]+)-amd64\\.msi"