-
Notifications
You must be signed in to change notification settings - Fork 1.6k
hwinfo: Refactor architecture handling #17099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR restructures the HWiNFO manifest configuration, moving architecture-specific binary mappings (bin and shortcuts) from root level into per-architecture blocks, converting pre_install arrays to single strings per architecture, and introducing new pre_uninstall and uninstaller logic for persist data management. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. hwinfo
|
|
I also implemented a more concise approach that dynamically creates architecture-specific shims and Start Menu shortcuts using However, I am not certain whether this approach is appropriate for the Extras bucket. |
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Summary
Refactors the
hwinfomanifest to use architecture-specific binaries, simplifies installation logic.Related issues or pull requests
Changes
binandshortcutsinto architecture-specific blocks to use original file names (HWiNFO64.exe,HWiNFO32.exe,HWiNFO_ARM64.exe) instead of renaming them.pre_installscripts by removing complex regex renaming logic and focusing on cleaning up irrelevant architecture binaries.persist_dataand addingpersist_permissionto ensure the application can write to its INI file.uninstallerblock for better lifecycle management.Testing
The test results are as follows:
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.