pritunl-client: Refactor manifest #17139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add arm64 version * Update checkver & autoupdate * Refactor service management logic
WalkthroughThis PR updates the Pritunl-Client Scoop manifest, restructuring the Windows installation process from direct downloads to scripted installers with automatic file renaming and expanded service management logic, while updating GitHub-based version detection and checksum verification. Changes
Sequence DiagramsequenceDiagram
participant User
participant Scoop as Scoop Installer
participant Installer as PowerShell Installer Script
participant FileSystem as File System
participant WinService as Windows Services
User->>Scoop: Install Pritunl-Client
Scoop->>Installer: Execute pre_install (PowerShell abort check)
Installer->>Scoop: Pre-install validation
Scoop->>Installer: Execute installer script (64bit/arm64)
Installer->>FileSystem: Remove old files (Clean-up)
Installer->>FileSystem: Download and rename .exe files
FileSystem->>Installer: Files ready
Scoop->>Installer: Execute post_install script
Installer->>WinService: Check for existing service
alt Service doesn't exist
Installer->>WinService: Create and register helper service
Installer->>FileSystem: Configure service in registry
else Service exists
Installer->>WinService: Register failure action recovery
end
WinService->>Installer: Service configured
Installer->>Scoop: Post-install complete
Scoop->>FileSystem: Create shims for pritunl.exe, pritunl-client.exe
FileSystem->>User: Installation complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
Contributor
|
All changes look good. Wait for review from human collaborators. pritunl-client
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refines service installation logic, and adds ARM64 support through post-extraction file management.
Related issues or pull requests
Changes
post_install.exewith native PowerShell service creation and hardening.Remove-Service(PS 6.0+) and adding explicit process termination.abortfor better integration with Scoop's error handling.HEADinstead ofmaster).suggestfield for Microsoft Visual C++ 2015-2022 Redistributable.binentries.Notes
,1are for the 64-bit architecture, while those with,2are for the ARM64 architecture.binfield changes:The previous manifest included
pritunl.exewith a--no-mainflag (added in Pritunl Client: Add version 1.0.1953.32 #2055). However, official documentation provides no information regarding this parameter, and its original purpose remains unclear.Testing indicates that while
--dev-toolsis a documented flag, the "Developer Tools" option appears in the UI menu regardless of whether the flag is passed, making it difficult to verify ifpritunl.execorrectly accepts CLI arguments.pritunl-client.exehas been confirmed to accept command-line arguments and is now included in thebinfield for better accessibility.Testing
The test results are as follows:
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
New Features
Improvements