-
Notifications
You must be signed in to change notification settings - Fork 1.6k
utpm: Add version 0.2.0 #17143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
utpm: Add version 0.2.0 #17143
Conversation
WalkthroughAdds a new JSON manifest Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with Invalid manifests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bucket/utpm.json`:
- Around line 20-22: The JSON for the "64bit" object contains a trailing comma
after the "url" property which makes the file invalid; remove the trailing comma
after the "url" value inside the "64bit" object (and scan the surrounding
objects for any other trailing commas) so the JSON parses correctly while
keeping the "64bit" key and its "url" property unchanged.
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with utpm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bucket/utpm.json`:
- Line 16: The hardcoded "bin" value in utpm.json points to the x86_64 folder
and breaks arm64 installs; update the manifest to provide architecture-specific
binary paths (e.g., separate entries or a map for
"utpm-x86_64-pc-windows-msvc/utpm.exe" and
"utpm-aarch64-pc-windows-msvc/utpm.exe") or change the consumer to compute the
"bin" path at runtime based on the platform/arch (use the archive folder names
utpm-x86_64-pc-windows-msvc and utpm-aarch64-pc-windows-msvc to select the
correct binary), and replace the single "bin" key accordingly so arm64 resolves
to the aarch64 directory.
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with utpm
|
Removed the hash URL entry from the utpm.json configuration.
|
/verify |
|
All changes look good. Wait for review from human collaborators. utpm
|
Added utpm manifest.
Closes #17142
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit