-
Notifications
You must be signed in to change notification settings - Fork 1.6k
eventghost: Add version 0.4.1.r1722 #17145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Removed the 'checkver' section to streamline configuration.
WalkthroughA new Scoop package manifest file for EventGhost is added, defining installation configuration for the Windows package manager. The manifest specifies version metadata, architecture-specific downloads, installer procedures, binary paths, shortcuts, persistent files, and automated version checking with GitHub integration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with eventghost
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bucket/eventghost.json`:
- Around line 45-48: The checkver block is missing an explicit URL scheme
causing CI to treat "EventGhost/EventGhost/releases/latest" as invalid; add a
new property checkver.url set to
"https://github.com/EventGhost/EventGhost/releases/latest" (keep the existing
checkver.github and checkver.regex unchanged) so the WebClient can fetch the
latest release via HTTPS.
| "checkver": { | ||
| "github": "EventGhost/EventGhost", | ||
| "regex": "v([\\d.]+\\.r\\d+)$" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix checkver URL to resolve CI failure (missing scheme).
CI reports EventGhost/EventGhost/releases/latest as an invalid URL. Add an explicit checkver.url with https:// so the WebClient call is valid and checkver can fetch the latest tag.
🔧 Proposed fix
"checkver": {
- "github": "EventGhost/EventGhost",
- "regex": "v([\\d.]+\\.r\\d+)$"
+ "url": "https://github.com/EventGhost/EventGhost/releases/latest",
+ "regex": "v([\\d.]+\\.r\\d+)$"
}🤖 Prompt for AI Agents
In `@bucket/eventghost.json` around lines 45 - 48, The checkver block is missing
an explicit URL scheme causing CI to treat
"EventGhost/EventGhost/releases/latest" as invalid; add a new property
checkver.url set to "https://github.com/EventGhost/EventGhost/releases/latest"
(keep the existing checkver.github and checkver.regex unchanged) so the
WebClient can fetch the latest release via HTTPS.
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit