antigravity: Update to version 2.0.1, fix checkver & autoupdate#17845
Merged
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Antigravity Scoop package manifest from v1.23.2 to v2.0.1. The manifest metadata and description reflect the transition to an agent orchestration platform. Download URLs and hashes are replaced with new Antigravity 2.0 artifact references using Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All changes look good. Wait for review from human collaborators. antigravity
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
bucket/antigravity.json (2)
52-74: Run the Scoop manifest validation flow before merge.Use:
scoop config debug true scoop config gh_token <your-github-token> # optional, read-only token .\bin\checkver.ps1 -App antigravity -f .\bin\formatjson.ps1 -App antigravity scoop install .\bucket\antigravity.json -a 64bit scoop install .\bucket\antigravity.json -a arm64Reference docs:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/antigravity.json` around lines 52 - 74, Run the Scoop manifest validation and local install tests for the antigravity manifest: validate the "checkver" regex/jsonpath and each "autoupdate" architecture block (64bit and arm64) by running the checkver and format flows, then attempt local installs for both architectures to ensure the "url" and "hash" endpoints return correct files and SHA256 via their "jsonpath" values; specifically exercise the checkver lookup, the autoupdate "architecture" entries, and the hash URLs to confirm $version/$matchBuild interpolation and that the regex and jsonpath extract the expected values before merging.
40-44: ⚡ Quick winGuard
app-update.ymlrewrite and tighten the match condition.Line 40 currently assumes the file exists, and Line 42 uses a broad
.Replace('url', ...). A missing file will fail install, and broad replacement can rewrite unintended substrings. AddTest-Pathand match only theurl:key.Proposed patch
"post_install": [ "# Disable built-in update mechanism to prevent conflicts with Scoop's update management", "$yaml = \"$dir\\resources\\app-update.yml\"", - "$content = Get-Content -Path $yaml | Foreach-Object {", - " if ($_.StartsWith('url')) { \"$($_.Replace('url', '# url')) # Disabled by Scoop\" } else { $_ }", - "}", - "Set-Content $yaml -Value $content -Encoding ascii" + "if (Test-Path $yaml) {", + " $content = Get-Content -Path $yaml | ForEach-Object {", + " if ($_ -match '^url\\s*:') { \"# $_ # Disabled by Scoop\" } else { $_ }", + " }", + " Set-Content -Path $yaml -Value $content -Encoding ascii", + "}" ]🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/antigravity.json` around lines 40 - 44, Guard the rewrite by checking the file exists (use Test-Path on $yaml) before calling Get-Content/Set-Content, and tighten the replacement so it only affects the YAML key named "url" (use a regex match like ^\s*url\s*: or -match on each $_ rather than StartsWith/Replace) and perform a targeted transformation (e.g. prefix the whole line with "# " or replace only the "url:" key) so other occurrences of the substring "url" are not altered; keep references to $yaml, Get-Content, Set-Content, and the per-line test/transform logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/antigravity.json`:
- Around line 52-74: Run the Scoop manifest validation and local install tests
for the antigravity manifest: validate the "checkver" regex/jsonpath and each
"autoupdate" architecture block (64bit and arm64) by running the checkver and
format flows, then attempt local installs for both architectures to ensure the
"url" and "hash" endpoints return correct files and SHA256 via their "jsonpath"
values; specifically exercise the checkver lookup, the autoupdate "architecture"
entries, and the hash URLs to confirm $version/$matchBuild interpolation and
that the regex and jsonpath extract the expected values before merging.
- Around line 40-44: Guard the rewrite by checking the file exists (use
Test-Path on $yaml) before calling Get-Content/Set-Content, and tighten the
replacement so it only affects the YAML key named "url" (use a regex match like
^\s*url\s*: or -match on each $_ rather than StartsWith/Replace) and perform a
targeted transformation (e.g. prefix the whole line with "# " or replace only
the "url:" key) so other occurrences of the substring "url" are not altered;
keep references to $yaml, Get-Content, Set-Content, and the per-line
test/transform logic.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fa4777cb-bc6c-4fd3-9374-ff2a3d629080
📒 Files selected for processing (1)
bucket/antigravity.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
This PR allows users who previously installed Antigravity IDE v1.x to upgrade to Antigravity 2.0, an agent orchestration platform.
I find this behavior a bit counterintuitive, though.
Closes #17833
Relates to #17834
Relates to #17840
<manifest-name[@version]|chore>: <general summary of the pull request>