cromite: Update to version 148.0.7778.168, fix checkver by o-l-a-v · Pull Request #17881 · ScoopInstaller/Extras

o-l-a-v · 2026-05-25T13:47:15Z

Closes #17880.
Relates to #17844.

Update to 148.0.7778.168
Simplify checkver: Use API directly + JSONPath to get latest stable tag_name

Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
I have read the Contributing Guide

coderabbitai · 2026-05-25T13:47:28Z

📝 Walkthrough

Walkthrough

This PR updates bucket/cromite.json: it bumps the manifest version from 147.0.7727.56 to 148.0.7778.168, replaces the Windows x64 download URL and its SHA256 hash to match the new release, and simplifies the checkver.regex to match tags of the form v- without a /releases/tag/ prefix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

ScoopInstaller/Extras#16381: Both PRs only update the respective Scoop manifests’ version/download url+hash and adjust checkver patterns/logic to match the new upstream release, so the change type and affected manifest fields overlap.
ScoopInstaller/Extras#17850: Both PRs update a Scoop manifest’s checkver tag-matching regex by removing the /releases/tag/-style prefix so GitHub tag names/version extraction works for new releases.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR directly addresses issue `#17880` by fixing the checkver regex pattern that was failing to match the release tag format, enabling the Excavator updater to correctly detect new releases.
Out of Scope Changes check	✅ Passed	All changes in the PR are scoped to the cromite manifest update and checkver simplification as specified in the linked issue, with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately summarizes the main changes: updating cromite to version 148.0.7778.168 and fixing the checkver implementation. It is concise, specific, and clearly communicates the primary purpose of the changeset.
Description check	✅ Passed	The PR description follows the required template structure and includes the conventional title format, issue references, and confirms reading the Contributing Guide.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

bucket/cromite.json (1)
40-51: Run the manifest validation flow before merge.

Please run:

scoop config debug true

scoop config gh_token <your-github-token> (optional, read-only)

.\bin\checkver.ps1 -App cromite -f

.\bin\formatjson.ps1 -App cromite

scoop install bucket/cromite.json -a 64bit

Also keep these handy for submission checks:

https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md

https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests

As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission" and "always provide a link to the official contribution guide or wiki".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/cromite.json` around lines 40 - 51, Run the manifest validation and
local install checks for the cromite manifest: enable debug with `scoop config
debug true`, optionally set `scoop config gh_token`, then run the checkver and
formatters (`.\bin\checkver.ps1 -App cromite -f` and `.\bin\formatjson.ps1 -App
cromite`) and attempt installing the 64bit manifest (`scoop install
bucket/cromite.json -a 64bit`); if validation fails, adjust the "checkver" block
(url, jsonpath, or regex "v([\\d.]+)-(?<sha>[0-9a-f]+)") or the "autoupdate"
64bit url template
(`https://github.com/uazo/cromite/releases/download/v$version-$matchSha/chrome-win.zip`)
until the checker and install succeed, and follow the contribution guide and
wiki for submission:
https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md and
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/cromite.json`:
- Around line 41-43: The current checkver JSONPath for cromite selects all
non-prerelease tags and can pick releases that lack the Windows asset; update
the "jsonpath" value in cromite.json so it filters releases to those whose
.assets array contains a browser_download_url matching the Windows zip (e.g.
using @.assets[?(@.browser_download_url =~ /chrome-win\\.zip/i)]) and still
returns the .tag_name (so keep the overall selector like $[?(@.prerelease==false
&& @.assets[?(@.browser_download_url =~ /chrome-win\.zip/i)])].tag_name); modify
the "jsonpath" entry accordingly in the cromite manifest.

---

Nitpick comments:
In `@bucket/cromite.json`:
- Around line 40-51: Run the manifest validation and local install checks for
the cromite manifest: enable debug with `scoop config debug true`, optionally
set `scoop config gh_token`, then run the checkver and formatters
(`.\bin\checkver.ps1 -App cromite -f` and `.\bin\formatjson.ps1 -App cromite`)
and attempt installing the 64bit manifest (`scoop install bucket/cromite.json -a
64bit`); if validation fails, adjust the "checkver" block (url, jsonpath, or
regex "v([\\d.]+)-(?<sha>[0-9a-f]+)") or the "autoupdate" 64bit url template
(`https://github.com/uazo/cromite/releases/download/v$version-$matchSha/chrome-win.zip`)
until the checker and install succeed, and follow the contribution guide and
wiki for submission:
https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md and
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 35cfe06a-771d-4d91-b234-56ab6c98dac7

📥 Commits

Reviewing files that changed from the base of the PR and between 14d7ef7 and 1955d38.

📒 Files selected for processing (1)

bucket/cromite.json

z-Fng · 2026-05-27T07:15:48Z

/verify

github-actions · 2026-05-27T07:17:30Z

All changes look good.

Wait for review from human collaborators.

cromite

Check the full log for details.

coderabbitai

♻️ Duplicate comments (1)

bucket/cromite.json (1)
42-42: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Constrain checkver to releases with chrome-win.zip asset.

The regex pattern is correct, but without a jsonpath filter, checkver may select releases that lack the Windows asset. As noted in the previous review, add a jsonpath constraint to filter for releases containing the chrome-win.zip asset.
Suggested fix
     "checkver": {
         "github": "https://github.com/uazo/cromite",
+        "jsonpath": "$[?(@.draft == false && @.prerelease == false && @.assets[?(@.browser_download_url =~ /chrome-win\\.zip$/i)])].tag_name",
         "regex": "v([\\d.]+)-(?<sha>[0-9a-f]+)"
     },
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/cromite.json` at line 42, The checkver config currently only has the
"regex": "v([\\d.]+)-(?<sha>[0-9a-f]+)" which can match tags from releases that
don't include the Windows asset; update the release check to include a jsonpath
filter that selects only releases containing an asset named "chrome-win.zip"
(add a "jsonpath" entry alongside the existing "regex" in cromite.json) so
checkver only considers releases with that asset.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@bucket/cromite.json`:
- Line 42: The checkver config currently only has the "regex":
"v([\\d.]+)-(?<sha>[0-9a-f]+)" which can match tags from releases that don't
include the Windows asset; update the release check to include a jsonpath filter
that selects only releases containing an asset named "chrome-win.zip" (add a
"jsonpath" entry alongside the existing "regex" in cromite.json) so checkver
only considers releases with that asset.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6445332a-d1c8-467e-b6d0-feaf94b57015

📥 Commits

Reviewing files that changed from the base of the PR and between 1955d38 and d460894.

📒 Files selected for processing (1)

bucket/cromite.json

z-Fng

Thanks for your contribution!

cromite: update to 148.0.7778.168 and simplify checkver

1955d38

o-l-a-v mentioned this pull request May 25, 2026

[Bug]: Excavator "couldn't match" for 100 manifests #17882

Closed

3 tasks

coderabbitai Bot reviewed May 25, 2026

View reviewed changes

Comment thread bucket/cromite.json Outdated

z-Fng requested changes May 27, 2026

View reviewed changes

Comment thread bucket/cromite.json Outdated

Explicitly specify GitHub mode

d460894

z-Fng changed the title ~~cromite: update to 148.0.7778.168 and simplify checkver~~ cromite: Update to version 148.0.7778.168, fix checkver May 27, 2026

github-actions Bot added the review-needed label May 27, 2026

coderabbitai Bot reviewed May 27, 2026

View reviewed changes

z-Fng approved these changes May 27, 2026

View reviewed changes

z-Fng merged commit 9231e89 into ScoopInstaller:master May 27, 2026
3 checks passed

z-Fng mentioned this pull request May 27, 2026

[Maintain] Adapt to Scoop-Core checkver breaking changes #17844

Open

7 tasks

coderabbitai Bot mentioned this pull request May 27, 2026

ungoogled-chromium: Update to version 148.0.7778.178-1.1, fix checkver, simplify autoupdate #17879

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cromite: Update to version 148.0.7778.168, fix checkver#17881

cromite: Update to version 148.0.7778.168, fix checkver#17881
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
o-l-a-v:patch-42

o-l-a-v commented May 25, 2026 •

edited by z-Fng

Loading

Uh oh!

coderabbitai Bot commented May 25, 2026 •

edited

Loading

Walkthrough

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

z-Fng commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

z-Fng left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

o-l-a-v commented May 25, 2026 • edited by z-Fng Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

z-Fng commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

cromite

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

z-Fng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

o-l-a-v commented May 25, 2026 •

edited by z-Fng

Loading

coderabbitai Bot commented May 25, 2026 •

edited

Loading