Skip to content

fluentcleaner: Add new manifest version 26.05.22#17886

Open
desk7 wants to merge 2 commits into
ScoopInstaller:masterfrom
desk7:fluentcleaner
Open

fluentcleaner: Add new manifest version 26.05.22#17886
desk7 wants to merge 2 commits into
ScoopInstaller:masterfrom
desk7:fluentcleaner

Conversation

@desk7

@desk7 desk7 commented May 26, 2026

Copy link
Copy Markdown
Contributor

Add fluentcleaner manifest

Closes #17885

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3e3c811f-c085-40d9-b618-50684d330f05

📥 Commits

Reviewing files that changed from the base of the PR and between 8fe64c6 and f099fda.

📒 Files selected for processing (1)
  • bucket/fluentcleaner.json
💤 Files with no reviewable changes (1)
  • bucket/fluentcleaner.json

📝 Walkthrough

Walkthrough

This PR introduces the FluentCleaner package to the Scoop Extras bucket by adding a new manifest file. The manifest declares version 26.05.22 of FluentCleaner, a WinUI desktop cleaner, and specifies the 64-bit download URL from GitHub releases along with its SHA256 hash. The file includes extraction directory configuration, desktop shortcut mapping, and autoupdate rules that automatically update the 64-bit download URL when new versions are released.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a new FluentCleaner manifest with version 26.05.22, using conventional format.
Description check ✅ Passed The PR description includes required elements: manifest addition summary, closed issue reference (#17885), and confirmed checklist items for conventional title and contributing guide.
Linked Issues check ✅ Passed The manifest satisfies all requirements from issue #17885: package name, homepage, download URL for version 26.05.22, and meets all acceptance criteria.
Out of Scope Changes check ✅ Passed All changes are scoped to adding the FluentCleaner manifest as requested in issue #17885; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/fluentcleaner.json (1)

1-23: Testing guidance for the manifest.

Before merging, please test the manifest locally using the following commands:

  1. Optional: Enable debug mode and set GitHub token (for GitHub API access):

    scoop config debug true
    scoop config gh_token <your-github-token>  # Read access only
  2. Force version detection and autoupdate:

    .\bin\checkver.ps1 -App fluentcleaner -f
  3. Auto-format (Lint) the JSON manifest:

    .\bin\formatjson.ps1 -App fluentcleaner
  4. Test installation:

    scoop install .\bucket\fluentcleaner.json -a 64bit
  5. Verify the application runs correctly and that the desktop shortcut works as expected.

For more details, see the Contribution Guide and App Manifests Wiki.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/fluentcleaner.json` around lines 1 - 23, Run the recommended local
validation for the fluentcleaner manifest: enable debug and set gh_token in
Scoop, run the checkver script for the fluentcleaner app (.\bin\checkver.ps1
-App fluentcleaner -f) to force version detection/autoupdate, run the JSON
formatter (.\bin\formatjson.ps1 -App fluentcleaner) to lint the manifest,
install the manifest locally for 64-bit (scoop install
.\bucket\fluentcleaner.json -a 64bit), and verify the application launches and
the desktop shortcut (FCleaner) works; if any issues appear, fix the manifest
fields in fluentcleaner.json (name, version, architecture.url, extract_dir,
shortcuts, autoupdate) accordingly and re-run these steps.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/fluentcleaner.json`:
- Around line 1-23: Run the recommended local validation for the fluentcleaner
manifest: enable debug and set gh_token in Scoop, run the checkver script for
the fluentcleaner app (.\bin\checkver.ps1 -App fluentcleaner -f) to force
version detection/autoupdate, run the JSON formatter (.\bin\formatjson.ps1 -App
fluentcleaner) to lint the manifest, install the manifest locally for 64-bit
(scoop install .\bucket\fluentcleaner.json -a 64bit), and verify the application
launches and the desktop shortcut (FCleaner) works; if any issues appear, fix
the manifest fields in fluentcleaner.json (name, version, architecture.url,
extract_dir, shortcuts, autoupdate) accordingly and re-run these steps.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7aa0d646-597f-45e2-9c06-6619f88c258e

📥 Commits

Reviewing files that changed from the base of the PR and between 689762e and 8fe64c6.

📒 Files selected for processing (1)
  • bucket/fluentcleaner.json

arvdk added a commit to arvdk/Extras that referenced this pull request Jun 9, 2026
@ExLei

ExLei commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

/verify

@github-actions

Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

fluentcleaner

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@FHYQ-Dong

Copy link
Copy Markdown
Contributor

Thanks for the manifest! One issue worth addressing: FluentCleaner is a framework-dependent WinUI 3 app (built against WindowsAppSDK 2.0.1, per FCleaner.deps.json), so on a machine without the Windows App Runtime it installs fine but fails at launch with:

Required components of the Windows App Runtime are missing — Version 2.x

Since the runtime is delivered as system-wide MSIX framework packages, Scoop can't ship it inside this manifest, but two options would save users the confusion:

  1. At minimum, add a notes entry pointing to the official installer, e.g.:
"notes": "FluentCleaner requires the Windows App Runtime 2.0: https://aka.ms/windowsappsdk/2.0/2.0.1/windowsappruntimeinstall-x64.exe"
  1. Or add a separate windows-app-runtime-2.0 manifest (vcredist2022-style: download the official installer, run it with --quiet in post_install) and reference it via "depends". Note the version line matters: each minor line is its own framework package family (Microsoft.WindowsAppRuntime.2.0 vs .2.1/.2.3), so installing the latest 2.3.x runtime does not satisfy a 2.0 app — a runtime manifest would need checkver pinned to the 2.0 line.

Happy to share a working runtime manifest if option 2 sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Fluent Cleaner

3 participants