fluentcleaner: Add new manifest version 26.05.22#17886
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR introduces the FluentCleaner package to the Scoop Extras bucket by adding a new manifest file. The manifest declares version 26.05.22 of FluentCleaner, a WinUI desktop cleaner, and specifies the 64-bit download URL from GitHub releases along with its SHA256 hash. The file includes extraction directory configuration, desktop shortcut mapping, and autoupdate rules that automatically update the 64-bit download URL when new versions are released. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/fluentcleaner.json (1)
1-23: Testing guidance for the manifest.Before merging, please test the manifest locally using the following commands:
Optional: Enable debug mode and set GitHub token (for GitHub API access):
scoop config debug true scoop config gh_token <your-github-token> # Read access onlyForce version detection and autoupdate:
.\bin\checkver.ps1 -App fluentcleaner -fAuto-format (Lint) the JSON manifest:
.\bin\formatjson.ps1 -App fluentcleanerTest installation:
scoop install .\bucket\fluentcleaner.json -a 64bitVerify the application runs correctly and that the desktop shortcut works as expected.
For more details, see the Contribution Guide and App Manifests Wiki.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/fluentcleaner.json` around lines 1 - 23, Run the recommended local validation for the fluentcleaner manifest: enable debug and set gh_token in Scoop, run the checkver script for the fluentcleaner app (.\bin\checkver.ps1 -App fluentcleaner -f) to force version detection/autoupdate, run the JSON formatter (.\bin\formatjson.ps1 -App fluentcleaner) to lint the manifest, install the manifest locally for 64-bit (scoop install .\bucket\fluentcleaner.json -a 64bit), and verify the application launches and the desktop shortcut (FCleaner) works; if any issues appear, fix the manifest fields in fluentcleaner.json (name, version, architecture.url, extract_dir, shortcuts, autoupdate) accordingly and re-run these steps.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/fluentcleaner.json`:
- Around line 1-23: Run the recommended local validation for the fluentcleaner
manifest: enable debug and set gh_token in Scoop, run the checkver script for
the fluentcleaner app (.\bin\checkver.ps1 -App fluentcleaner -f) to force
version detection/autoupdate, run the JSON formatter (.\bin\formatjson.ps1 -App
fluentcleaner) to lint the manifest, install the manifest locally for 64-bit
(scoop install .\bucket\fluentcleaner.json -a 64bit), and verify the application
launches and the desktop shortcut (FCleaner) works; if any issues appear, fix
the manifest fields in fluentcleaner.json (name, version, architecture.url,
extract_dir, shortcuts, autoupdate) accordingly and re-run these steps.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7aa0d646-597f-45e2-9c06-6619f88c258e
📒 Files selected for processing (1)
bucket/fluentcleaner.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with fluentcleaner
|
|
Thanks for the manifest! One issue worth addressing: FluentCleaner is a framework-dependent WinUI 3 app (built against WindowsAppSDK 2.0.1, per FCleaner.deps.json), so on a machine without the Windows App Runtime it installs fine but fails at launch with: Required components of the Windows App Runtime are missing — Version 2.x Since the runtime is delivered as system-wide MSIX framework packages, Scoop can't ship it inside this manifest, but two options would save users the confusion:
"notes": "FluentCleaner requires the Windows App Runtime 2.0: https://aka.ms/windowsappsdk/2.0/2.0.1/windowsappruntimeinstall-x64.exe"
Happy to share a working runtime manifest if option 2 sounds reasonable. |
Add fluentcleaner manifest
Closes #17885
<manifest-name[@version]|chore>: <general summary of the pull request>