Skip to content

fluxdown: Add version 0.2.1#18232

Open
ExLei wants to merge 4 commits into
ScoopInstaller:masterfrom
ExLei:add-fluxdown
Open

fluxdown: Add version 0.2.1#18232
ExLei wants to merge 4 commits into
ScoopInstaller:masterfrom
ExLei:add-fluxdown

Conversation

@ExLei

@ExLei ExLei commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Add FluxDown - a free, blazing-fast multi-protocol download manager (IDM alternative) powered by a Rust engine.

Closes #17922

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updates the FluxDown Scoop manifest to version 0.2.1. The manifest refreshes metadata, installation notes, 64-bit and arm64 portable release URLs and hashes, pre-install initialization, shortcut configuration, persisted paths, and GitHub-based version checking and autoupdate templates.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The manifest adds FluxDown as a portable ZIP Scoop package and updates it to 0.2.1, matching the issue's package and version goals.
Out of Scope Changes check ✅ Passed The changes stay within the manifest update scope and do not introduce unrelated code or config outside the FluxDown package metadata.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly summarizes the main change: adding FluxDown version 0.2.1.
Description check ✅ Passed The description includes a concise summary, issue reference, and required checklist items, with only template comments left implicit.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ExLei

This comment was marked as resolved.

1 similar comment
@ExLei

This comment was marked as resolved.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

fluxdown

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@ExLei

ExLei commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

fluxdown

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@ExLei

ExLei commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@z-Fng

Comment thread bucket/fluxdown.json Outdated
Comment thread bucket/fluxdown.json Outdated
Comment thread bucket/fluxdown.json Outdated
Comment thread bucket/fluxdown.json Outdated
Comment thread bucket/fluxdown.json Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/fluxdown.json`:
- Around line 36-39: Update the pre_install commands in the fluxdown manifest to
persist flux_down.db and settings.json through $persist_dir, following the
existing bucket/beyondcompare.json copy-in/copy-out pattern instead of creating
placeholders under $dir. Also replace the hardcoded cli-v0.2.1 note with
cli-v$version.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 62fbf9d0-3c62-44c6-b236-723585c59e73

📥 Commits

Reviewing files that changed from the base of the PR and between c7a1b52 and d835a3b.

📒 Files selected for processing (1)
  • bucket/fluxdown.json

Comment thread bucket/fluxdown.json
@ExLei ExLei force-pushed the add-fluxdown branch 2 times, most recently from 33223cf to d48cbed Compare July 15, 2026 13:42
@ExLei ExLei changed the title fluxdown: Add version 0.1.55 fluxdown: Add version 0.2.1 Jul 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

fluxdown

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@ExLei

ExLei commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

fluxdown

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@ExLei

ExLei commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@z-Fng Thanks for the thorough review. All feedback addressed:

Applied:

  • Shortened description as suggested
  • Removed bin — confirmed flux_down.exe is GUI-only; the CLI (fluxdown.exe) is a separate binary not in the portable zip (added download note)
  • Removed uninstaller — shortcuts are handled by Scoop
  • autoupdate.hash.url$baseurl/SHA256SUMS.txt

What took so long: spent most of the time debugging persist failures that turned out to be stale files in $persist_dir from mixing different manifest iterations during testing, not a code issue a timing bug in the original commit: settings.json was placed in post_install, which runs after Scoop's persist step, causing it to be created as a directory junction on first install. The original pre_install + persist hardlink approach works correctly After moving both files into pre_install, download history, window position, and theme all persist through updates. Verified end-to-end with v0.1.55 → v0.2.1 upgrade.

Bumped version to v0.2.1. Ready for re-review.

@ExLei ExLei requested a review from z-Fng July 15, 2026 14:05
@ExLei

ExLei commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

One more finding: the original commit placed settings.json creation in post_install, which runs after Scoop's persist step. On first install, if settings.json doesn't exist yet, persist creates it as a directory junction, then post_install can't overwrite it. Fixed by moving everything into pre_install.

@ExLei

ExLei commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Prepared persist layout for the upcoming portable_data/ migration (refs zerx-lab/FluxDown#91).

Starting v0.3, FluxDown relocates portable runtime data from exe root into a unified portable_data/ subdirectory to keep the app root clean.

Three changes:

  1. pre_install — create portable_data/ dir first, so Scoop persist step handles it as a directory junction rather than falling back to copy.
  2. persist — add portable_data/ to the persist list alongside the old root-level items.
  3. notes — update all file paths to reflect portable_data/ prefix.

Old root-level persist entries (flux_down.db, bt_session, settings.json, logs) are deliberately kept. The app includes built-in migration logic that rename()s these hardlinks into portable_data/ on first launch. This lets existing 0.2.x users upgrade without data loss. They can be dropped in a follow-up manifest once users have migrated.

ExLei added 4 commits July 16, 2026 02:29
- Free, blazing-fast multi-protocol download manager (IDM alternative)
- Powered by Rust engine, supports HTTP/HTTPS/FTP/BitTorrent/HLS
- x64 + arm64 portable install with Start Menu shortcut
- Persist: flux_down.db, bt_session, settings.json, logs
- Autoupdate with SHA256SUMS hash extraction
- AGPL-3.0-only

Closes ScoopInstaller#17922
- Shorten description per z-Fng's suggestion
- Remove bin (flux_down.exe is GUI-only)
- Remove uninstaller (shortcuts managed by Scoop; no Stop-Process)
- Use $baseurl in autoupdate hash URL per z-Fng's suggestion
- Keep original pre_install/persist from author's working bucket
- Add CLI download note with $version
…aller#91)

FluxDown v0.3+ moves portable runtime data from exe root into
portable_data/ subdirectory (zerx-lab/FluxDown#91).

- persist: add portable_data/ so Scoop hardlinks the new data directory
- pre_install: create portable_data/ dir first so persist step handles
  it as a directory junction
- notes: update all data path references to portable_data/ prefix

Old root-level persist items (flux_down.db, bt_session, settings.json,
logs) are kept for seamless 0.2.x→0.3.0 upgrades: the app's built-in
migration code rename()s existing hardlinks from root into portable_data/
on first launch. They can be removed in a follow-up once users have
upgraded.
@ExLei

ExLei commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

fluxdown

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: FluxDown

2 participants