Skip to content

imagemagick@7.1.2-8 & imagemagick-lean@7.1.2-8: Use GitHub for checkver and download#7231

Merged
Lutra-Fs merged 6 commits intoScoopInstaller:masterfrom
o-l-a-v:7230-imagemagick-change-dl-url
Oct 31, 2025
Merged

imagemagick@7.1.2-8 & imagemagick-lean@7.1.2-8: Use GitHub for checkver and download#7231
Lutra-Fs merged 6 commits intoScoopInstaller:masterfrom
o-l-a-v:7230-imagemagick-change-dl-url

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Oct 7, 2025

Closes #7230.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by hooman

  • Both: Use GitHub releases for checkver and download, because downloading from imagemagick.org was very slow
  • Both: Reorder JSON elements to match wanted order
  • imagemagick-lean: Update to v7.1.2-5
  • imagemagick-lean: GitHub releases has .7z of portable packages instead of .zip, with no directory inside. Removed extract_dir.

Summary by CodeRabbit

  • Chores

    • Updated ImageMagick and lean variant to 7.1.2-5.
    • Switched downloads and version tracking to GitHub Releases for more reliable installs and updates across all architectures.
    • Automatically adds the package to PATH for easier command usage.
  • Documentation

    • Added guidance on Ghostscript requirements and using “magick convert” instead of deprecated convert.exe.
    • Clarified that the lean manifest is a minimal install and recommends the full package for complete DLLs and environment configuration.

@o-l-a-v o-l-a-v changed the title ImageMagick@7.1.2-5: Use GitHub for checkver and download imagemagick@7.1.2-5: Use GitHub for checkver and download Oct 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 7, 2025

Walkthrough

Updates Scoop manifests for ImageMagick and ImageMagick Lean: migrate downloads/checkver/autoupdate from ImageMagick.org RDF/digest endpoints to GitHub Releases, refresh URLs and hashes for all architectures, add/adjust notes and environment settings, and bump the lean manifest version from 7.1.2-3 to 7.1.2-5.

Changes

Cohort / File(s) Summary of edits
GitHub Releases migration (downloads, hashes)
bucket/imagemagick.json, bucket/imagemagick-lean.json
Switched all architecture assets (x86/x64/arm64) to GitHub Releases download URLs; replaced old archive.binaries/ImageMagick.org links; updated SHA256 hashes accordingly.
checkver + autoupdate rework
bucket/imagemagick.json, bucket/imagemagick-lean.json
Replaced RDF/digest-based checkver with GitHub API latest release (jsonpath tag_name); refactored autoupdate URL templates per-arch to GitHub patterns using $version; removed digest.rdf settings and related extract_dir fields.
Version and manifest notes
bucket/imagemagick-lean.json
Version bump 7.1.2-3 → 7.1.2-5; added notes clarifying lean install scope and suggesting full imagemagick for DLLs/env vars.
Environment and guidance
bucket/imagemagick.json
Added env_add_path "."; retained env_set; added notes on Ghostscript requirement and convert.exe deprecation (use “magick convert”).
Architecture block organization
bucket/imagemagick.json, bucket/imagemagick-lean.json
Reordered/standardized architecture sections; consolidated 32bit/64bit/arm64 entries under unified GitHub-based patterns.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Scoop as Scoop (client)
  participant GHAPI as GitHub API (releases/latest)
  participant GH as GitHub Releases (assets)

  User->>Scoop: scoop install/update imagemagick(‑lean)
  Scoop->>GHAPI: GET latest release (tag_name)
  GHAPI-->>Scoop: tag_name (e.g., 7.1.2-5)
  Scoop->>Scoop: Resolve arch-specific URL via autoupdate template
  Scoop->>GH: Download installer/archive for x86/x64/arm64
  GH-->>Scoop: Asset bytes
  Scoop->>Scoop: Verify SHA256, extract, set env (if defined)
  Scoop-->>User: Install/update complete
  note over Scoop,GH: New flow uses GitHub Releases and JSON tag lookup
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I hop through tags where releases gleam,
From RDF burrows to GitHub’s stream.
New hashes crisp, the mirrors quick—
A speedy sip for every pick.
Lean or full, I twitch with cheer:
magick on PATH, updates near. ✨🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes Check ⚠️ Warning The pull request introduces environment configuration settings (env_add_path) and guidance notes about Ghostscript requirements and the deprecation of convert.exe, which were not part of the original issue’s scope of migrating download sources to GitHub. Please remove or isolate the environment configuration and user guidance notes into a separate PR so that this change set focuses solely on migrating the download and checkver sources to GitHub as requested in issue #7230.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues Check ✅ Passed The changes fully implement the issue’s request to use GitHub releases for ImageMagick downloads and update the checkver source to the GitHub API, covering all specified architectures and aligning with the objectives of issue #7230.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The PR description includes the required “Closes #7230” directive and both mandatory checklist items are marked complete, aligning with the repository’s template for PR descriptions.
Title Check ✅ Passed The PR title "imagemagick@7.1.2-8 & imagemagick-lean@7.1.2-8: Use GitHub for checkver and download" accurately describes the main functional change in the changeset: migrating both manifest files to use GitHub as the source for checkver and downloads instead of the previous sources. Both the imagemagick-lean.json and imagemagick.json files have been updated to switch from their original download sources (ImageMagick.org archives and aDigest RDF endpoints) to GitHub Releases with corresponding checkver configuration changes. The title's functional description directly aligns with the primary objective stated in the linked issue #7230 (use GitHub releases as the download source). While the version numbers in the title may differ from those shown in the changeset details (which reference 7.1.2-5 for lean), this does not undermine the core message that the title conveys about the nature of the changes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

All changes look good.

Wait for review from human collaborators.

imagemagick-lean

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

imagemagick

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@Lutra-Fs
Copy link
Member

Hi, can you resolve the conflict?

@o-l-a-v o-l-a-v changed the title imagemagick@7.1.2-5: Use GitHub for checkver and download imagemagick@7.1.2-8 & imagemagick-lean@7.1.2-8: Use GitHub for checkver and download Oct 29, 2025
@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 29, 2025

@Lutra-Fs: Fixed, updated both to 7.1.2-8.

@Lutra-Fs
Copy link
Member

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

imagemagick-lean

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

imagemagick

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@Lutra-Fs Lutra-Fs merged commit c13d925 into ScoopInstaller:master Oct 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ImageMagick download is very slow

2 participants