Skip to content

Conversation

@lvyuemeng
Copy link
Contributor

@lvyuemeng lvyuemeng commented Jan 13, 2026

Closes: #7528

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features

    • Added VMR (v0.7.5) package with multi-architecture support for 64-bit and ARM64 systems, enabling automated installation and version updates
  • Updates

    • Restructured installation configurations and dependency handling for multiple packages (Android Payload Dumper, Gig, SlikSVN, Zigup) to improve compatibility

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Walkthrough

This PR modifies multiple Scoop package manifests in the bucket directory, including restructuring metadata in android-payload-dumper.json and zigup.json, changing field types from arrays to strings in gig.json and sliksvn.json, and adding a new vmr.json manifest for a version manager tool.

Changes

Cohort / File(s) Summary
Manifest restructuring
bucket/android-payload-dumper.json, bucket/zigup.json
Reorganized JSON structure: moved update metadata under autoupdate, added inline hash fields to architecture entries, introduced bin and checkver fields; zigup converted from partial to complete explicit manifest with environment and persistence settings.
Field type conversions
bucket/gig.json, bucket/sliksvn.json
Changed field types: gig.json converts "depends" from array to string; sliksvn.json converts "pre_install" from single-element array to string.
New manifest
bucket/vmr.json
Added new Scoop package manifest for VMR (version manager) v0.7.5 with 64bit and arm64 architecture support, SHA-256 hashes, GitHub-based version checking, and autoupdate configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 A rabbit hops through JSON neat,
Restructuring each field so sweet,
New vmr manifest joins the fold,
With hashes bright and versions bold!
The manifests now shine so bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning Changes to android-payload-dumper.json, gig.json, sliksvn.json, and zigup.json appear to be unrelated to the Vmr v0.7.5 package request in issue #7528. Remove or justify changes to android-payload-dumper.json, gig.json, sliksvn.json, and zigup.json as they are out of scope for the Vmr package request.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Vmr: Add version 0.7.5' is specific and clearly describes the main change in the PR—adding version 0.7.5 of the Vmr manifest.
Description check ✅ Passed The PR description follows the template, includes the issue reference (Closes: #7528), confirms conventional PR title format, and indicates reading the Contributing Guide.
Linked Issues check ✅ Passed The PR adds bucket/vmr.json with version 0.7.5, meeting all acceptance criteria from issue #7528: reasonably well-known project, English documentation, latest stable version, full version, and standard install process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

android-payload-dumper

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

gig

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

sliksvn

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

vmr

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

zigup

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@lvyuemeng lvyuemeng closed this Jan 13, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @bucket/android-payload-dumper.json:
- Around line 18-29: The autoupdate URLs under the "autoupdate" block are
hardcoded to version 1.2.2; update the "architecture" entries ("64bit" and
"32bit") and the "hash" url to use the $version placeholder instead of the
literal 1.2.2 so the release paths are generated dynamically (replace the
version in the filename and path with $version for payload-dumper-go download
URLs and the sha256checksums URL).
🧹 Nitpick comments (1)
bucket/vmr.json (1)

9-13: Use lowercase hash values for consistency.

Scoop manifests conventionally use lowercase hexadecimal for SHA-256 hashes. The current uppercase hashes work but deviate from the convention seen in other manifests in this repository.

🔧 Suggested fix
         "64bit": {
             "url": "https://github.com/gvcgo/version-manager/releases/download/v0.7.5/vmr_windows-amd64.zip",
-            "hash": "8EEE6C8B2E8AF68184239CBC5FA3F2A49D1352B4E9E28A74206C5B374A42EEF7"
+            "hash": "8eee6c8b2e8af68184239cbc5fa3f2a49d1352b4e9e28a74206c5b374a42eef7"
         },
         "arm64": {
             "url": "https://github.com/gvcgo/version-manager/releases/download/v0.7.5/vmr_windows-arm64.zip",
-            "hash": "3D9FEBAB6A3BB68808F098A65FD26637D5B6FE402ECE258D79FC124104C14725"
+            "hash": "3d9febab6a3bb68808f098a65fd26637d5b6fe402ece258d79fc124104c14725"
         }
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eab15ab and 3317e09.

📒 Files selected for processing (5)
  • bucket/android-payload-dumper.json
  • bucket/gig.json
  • bucket/sliksvn.json
  • bucket/vmr.json
  • bucket/zigup.json
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: narnaud
Repo: ScoopInstaller/Main PR: 7171
File: bucket/clink-flex-prompt.json:30-35
Timestamp: 2025-09-13T06:49:53.420Z
Learning: In Scoop package management, users typically upgrade packages rather than explicitly removing old versions. The `scoop cleanup` command and manual version removal are uncommon workflows, so optimizing for the primary upgrade scenario is reasonable.
🪛 GitHub Actions: Pull Requests
bucket/android-payload-dumper.json

[error] 1-1: Autoupdate failed. Could not update android-payload-dumper, hash for payload-dumper-go_1.3.0_windows_386.tar.gz failed!

🔇 Additional comments (4)
bucket/gig.json (1)

6-6: LGTM!

Valid simplification — Scoop accepts both string and array formats for single dependencies.

bucket/sliksvn.json (1)

20-20: LGTM!

Valid simplification — single-command pre_install can be expressed as a string.

bucket/zigup.json (1)

1-33: LGTM!

Well-structured manifest update with:

  • Proper $version placeholder in autoupdate URL
  • Correct shim configuration with --path-link for persistent zig binary
  • Version regex matching the v2025_01_02 format
bucket/vmr.json (1)

1-30: Well-structured manifest for Vmr.

The manifest correctly implements:

  • Architecture-specific payloads for 64bit and arm64
  • Proper $version placeholders in autoupdate URLs
  • GitHub-based version checking

Consider adding a hash section under autoupdate if the releases include a checksums file, which would enable automatic hash verification during updates.

@z-Fng z-Fng changed the title Vmr: Add version 0.7.5 vmr: Add version 0.7.5 Jan 13, 2026
@z-Fng z-Fng added the duplicate This issue or pull request already exists label Jan 13, 2026
@z-Fng
Copy link
Member

z-Fng commented Jan 13, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists manifest-fix-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Vmr

2 participants