-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
vmr: Add version 0.7.5 #7529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmr: Add version 0.7.5 #7529
Conversation
WalkthroughThis PR modifies multiple Scoop package manifests in the bucket directory, including restructuring metadata in android-payload-dumper.json and zigup.json, changing field types from arrays to strings in gig.json and sliksvn.json, and adding a new vmr.json manifest for a version manager tool. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with android-payload-dumper
gig
sliksvn
vmr
zigup
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @bucket/android-payload-dumper.json:
- Around line 18-29: The autoupdate URLs under the "autoupdate" block are
hardcoded to version 1.2.2; update the "architecture" entries ("64bit" and
"32bit") and the "hash" url to use the $version placeholder instead of the
literal 1.2.2 so the release paths are generated dynamically (replace the
version in the filename and path with $version for payload-dumper-go download
URLs and the sha256checksums URL).
🧹 Nitpick comments (1)
bucket/vmr.json (1)
9-13: Use lowercase hash values for consistency.Scoop manifests conventionally use lowercase hexadecimal for SHA-256 hashes. The current uppercase hashes work but deviate from the convention seen in other manifests in this repository.
🔧 Suggested fix
"64bit": { "url": "https://github.com/gvcgo/version-manager/releases/download/v0.7.5/vmr_windows-amd64.zip", - "hash": "8EEE6C8B2E8AF68184239CBC5FA3F2A49D1352B4E9E28A74206C5B374A42EEF7" + "hash": "8eee6c8b2e8af68184239cbc5fa3f2a49d1352b4e9e28a74206c5b374a42eef7" }, "arm64": { "url": "https://github.com/gvcgo/version-manager/releases/download/v0.7.5/vmr_windows-arm64.zip", - "hash": "3D9FEBAB6A3BB68808F098A65FD26637D5B6FE402ECE258D79FC124104C14725" + "hash": "3d9febab6a3bb68808f098a65fd26637d5b6fe402ece258d79fc124104c14725" }
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
bucket/android-payload-dumper.jsonbucket/gig.jsonbucket/sliksvn.jsonbucket/vmr.jsonbucket/zigup.json
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: narnaud
Repo: ScoopInstaller/Main PR: 7171
File: bucket/clink-flex-prompt.json:30-35
Timestamp: 2025-09-13T06:49:53.420Z
Learning: In Scoop package management, users typically upgrade packages rather than explicitly removing old versions. The `scoop cleanup` command and manual version removal are uncommon workflows, so optimizing for the primary upgrade scenario is reasonable.
🪛 GitHub Actions: Pull Requests
bucket/android-payload-dumper.json
[error] 1-1: Autoupdate failed. Could not update android-payload-dumper, hash for payload-dumper-go_1.3.0_windows_386.tar.gz failed!
🔇 Additional comments (4)
bucket/gig.json (1)
6-6: LGTM!Valid simplification — Scoop accepts both string and array formats for single dependencies.
bucket/sliksvn.json (1)
20-20: LGTM!Valid simplification — single-command
pre_installcan be expressed as a string.bucket/zigup.json (1)
1-33: LGTM!Well-structured manifest update with:
- Proper
$versionplaceholder in autoupdate URL- Correct shim configuration with
--path-linkfor persistent zig binary- Version regex matching the
v2025_01_02formatbucket/vmr.json (1)
1-30: Well-structured manifest for Vmr.The manifest correctly implements:
- Architecture-specific payloads for 64bit and arm64
- Proper
$versionplaceholders in autoupdate URLs- GitHub-based version checking
Consider adding a
hashsection underautoupdateif the releases include a checksums file, which would enable automatic hash verification during updates.
Closes: #7528
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
New Features
Updates
✏️ Tip: You can customize this high-level summary in your review settings.