eac3to@3.57: swapping file source for one allowing autoupdate and recognition #7555
Conversation
|
All changes look good. Wait for review from human collaborators. eac3to
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThis change updates the eac3to manifest file, bumping the version from 3.52 to 3.57 and migrating all download and version-checking URLs from rationalqm.us to videohelp.com. The update includes adjusting the version detection regex to match the new site's page format. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bucket/eac3to.json`:
- Around line 6-7: The "url" in eac3to.json points to a redirecting HTML page
and the "hash" cannot be verified; fix by replacing the broken download link and
hash or marking the entry as unavailable: locate a direct download URL for
eac3to_3.57.rar (or an authoritative mirror) and update the "url" field,
download the actual RAR, compute its SHA256 and update the "hash" field to that
value, or if no direct source exists remove or add a "deprecated": true (or
"unavailable": true) flag to the eac3to.json entry so CI won't attempt
validation; make changes to the "url" and "hash" fields in eac3to.json (or add
the deprecation flag) accordingly.
bucket/eac3to.json
Outdated
| "url": "https://www.videohelp.com/download/eac3to_3.57.rar", | ||
| "hash": "0C9650028167162F458CADA8E6AA702A66A35F09B5F1ACB7E4D744F8C3D8500D", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, check if the file exists and show its contents
cd /tmp && git -C /tmp show HEAD:bucket/eac3to.json 2>/dev/null || cat bucket/eac3to.json 2>/dev/null || fd -t f "eac3to.json" | head -1 | xargs catRepository: ScoopInstaller/Main
Length of output: 45
🏁 Script executed:
# Find the eac3to.json file
fd -t f "eac3to.json"Repository: ScoopInstaller/Main
Length of output: 81
🏁 Script executed:
# Read the eac3to.json file
cat bucket/eac3to.jsonRepository: ScoopInstaller/Main
Length of output: 625
🏁 Script executed:
# Verify the download URL is accessible and check hash
curl -sI "https://www.videohelp.com/download/eac3to_3.57.rar" 2>&1 | head -n 5Repository: ScoopInstaller/Main
Length of output: 240
🏁 Script executed:
# Download the file and verify hash
TEMP_FILE=$(mktemp)
timeout 30 curl -sL "https://www.videohelp.com/download/eac3to_3.57.rar" -o "$TEMP_FILE" 2>&1
# Check if file was downloaded and get its size
if [ -f "$TEMP_FILE" ]; then
FILE_SIZE=$(stat -c%s "$TEMP_FILE" 2>/dev/null || stat -f%z "$TEMP_FILE" 2>/dev/null)
echo "Downloaded file size: $FILE_SIZE bytes"
# Calculate SHA256 hash
ACTUAL_HASH=$(sha256sum "$TEMP_FILE" 2>/dev/null | awk '{print toupper($1)}')
EXPECTED_HASH="0C9650028167162F458CADA8E6AA702A66A35F09B5F1ACB7E4D744F8C3D8500D"
echo "Expected hash: $EXPECTED_HASH"
echo "Actual hash: $ACTUAL_HASH"
if [ "$ACTUAL_HASH" = "$EXPECTED_HASH" ]; then
echo "✓ Hash matches"
else
echo "✗ Hash mismatch"
fi
else
echo "Failed to download file"
fi
rm -f "$TEMP_FILE"Repository: ScoopInstaller/Main
Length of output: 249
🏁 Script executed:
# Try to get more info about the URL with redirects
curl -sI -L "https://www.videohelp.com/download/eac3to_3.57.rar" 2>&1 | head -n 20Repository: ScoopInstaller/Main
Length of output: 890
🏁 Script executed:
# Try downloading with proper headers and follow redirects
TEMP_FILE=$(mktemp)
curl -sL -A "Mozilla/5.0" "https://www.videohelp.com/download/eac3to_3.57.rar" -o "$TEMP_FILE" 2>&1
# Check file size and content
FILE_SIZE=$(wc -c < "$TEMP_FILE" 2>/dev/null)
echo "File size: $FILE_SIZE bytes"
# Check first few bytes to see what was actually downloaded
hexdump -C "$TEMP_FILE" 2>/dev/null | head -5 || od -A x -t x1z -v "$TEMP_FILE" 2>/dev/null | head -5
# Check if it's HTML (redirect page)
head -c 500 "$TEMP_FILE" | strings | head -10
rm -f "$TEMP_FILE"Repository: ScoopInstaller/Main
Length of output: 149
🏁 Script executed:
# Download the file again and compute hash
TEMP_FILE=$(mktemp)
curl -sL -A "Mozilla/5.0" "https://www.videohelp.com/download/eac3to_3.57.rar" -o "$TEMP_FILE" 2>&1
# Get file info
FILE_SIZE=$(wc -c < "$TEMP_FILE")
echo "File size: $FILE_SIZE bytes"
# Check if it's HTML content
head -c 200 "$TEMP_FILE"
echo ""
echo "---"
# Calculate hash
ACTUAL_HASH=$(sha256sum "$TEMP_FILE" 2>/dev/null | awk '{print toupper($1)}')
EXPECTED_HASH="0C9650028167162F458CADA8E6AA702A66A35F09B5F1ACB7E4D744F8C3D8500D"
echo "Expected hash: $EXPECTED_HASH"
echo "Actual hash: $ACTUAL_HASH"
if [ "$ACTUAL_HASH" = "$EXPECTED_HASH" ]; then
echo "✓ Hash matches"
else
echo "✗ Hash does not match"
fi
rm -f "$TEMP_FILE"Repository: ScoopInstaller/Main
Length of output: 408
Download URL is broken and hash cannot be verified.
The URL https://www.videohelp.com/download/eac3to_3.57.rar returns a 302 redirect to an HTML page instead of the actual RAR file. The provided hash cannot be validated against the actual downloadable file since the direct download link appears to be broken or the website has changed its download mechanism.
🤖 Prompt for AI Agents
In `@bucket/eac3to.json` around lines 6 - 7, The "url" in eac3to.json points to a
redirecting HTML page and the "hash" cannot be verified; fix by replacing the
broken download link and hash or marking the entry as unavailable: locate a
direct download URL for eac3to_3.57.rar (or an authoritative mirror) and update
the "url" field, download the actual RAR, compute its SHA256 and update the
"hash" field to that value, or if no direct source exists remove or add a
"deprecated": true (or "unavailable": true) flag to the eac3to.json entry so CI
won't attempt validation; make changes to the "url" and "hash" fields in
eac3to.json (or add the deprecation flag) accordingly.
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with eac3to
|
1 participant
Closes #7554
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.