Added simple no proxy functionality#4117
Open
zie-pao wants to merge 1 commit intoScoopInstaller:masterfrom
Open
Added simple no proxy functionality#4117zie-pao wants to merge 1 commit intoScoopInstaller:masterfrom
zie-pao wants to merge 1 commit intoScoopInstaller:masterfrom
Conversation
c33s
reviewed
Apr 28, 2021
| $wreq.headers.add('Cookie', (cookie_header $cookies)) | ||
|
|
||
| if($no_proxy) { | ||
| if($reqUrl -like "*$no_proxy*") { |
Contributor
There was a problem hiding this comment.
i think the matching should be improved. having the url example.org and NO_PROXY= 192.168.0.1,localhost,www.example.org would lead to a match but should not match. also NO_PROXY should also support wildcards *,example.org
|
A new updated PR to fix this problem: #6550 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to implement a simnple no proxy mechanism. It sets the no proxy environment variable for git requests and removed the proxy on installation of the url matches (like) the no proxy host.
I am not aware of othere parts in the code where these changes have to be done but so far it works for me. This should also fix #1820