gcc-arm-none-eabi10.3: Add version 10.3-2021.10#2656
gcc-arm-none-eabi10.3: Add version 10.3-2021.10#2656JalonWong wants to merge 1 commit intoScoopInstaller:masterfrom
Conversation
WalkthroughAdds a new manifest file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. gcc-arm-none-eabi10
|
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/gcc-arm-none-eabi10.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (1)
bucket/gcc-arm-none-eabi10.json (1)
6-6: Verify the download URL is accessible and confirm 32-bit-only support is intentional.The manifest hardcodes the download URL to the 32-bit (
win32) Windows variant only. Clarify whether:
- The 64-bit (
win64) variant is intentionally omitted- Users needing 64-bit support should use a different manifest
- ARM provides both variants for this version
If 64-bit support is needed, the manifest may need additional configuration or a separate manifest for the x64 variant.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
bucket/gcc-arm-none-eabi10.3.json (2)
6-9: LGTM: Download and extraction configuration is correct.The download URL, extraction directory, and binary path exposure are properly configured for this ARM GCC toolchain version.
Note: The MD5 hash issue on line 7 has already been flagged in previous reviews.
14-21: Autoupdate hash-finding issue already flagged.The broken hash-finding regex on line 19 has been thoroughly documented in previous reviews. Additionally, when this is fixed, ensure the regex extracts SHA256 hashes rather than MD5 to align with the security improvements suggested for line 7.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/gcc-arm-none-eabi10.3.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/gcc-arm-none-eabi10.3.json (3)
1-2: LGTM: Version declaration is correct.The version "10.3-2021.10" matches the ARM GNU Toolchain release format for this specific stable release.
1-22: Overall manifest structure is sound; address flagged issues before merging.The Scoop manifest follows proper conventions and appropriately targets the specific 10.3-2021.10 release. The critical issues to address before merging are:
- Security: Update from MD5 to SHA256 hash (line 7, already flagged)
- Autoupdate: Fix the broken hash-finding regex (lines 19, already flagged)
- License: Verify the SPDX identifier is correct (line 5, new check requested)
The checkver regex (lines 10-13) is actually appropriate for this version-specific manifest, contrary to a previous review comment.
10-13: The checkver regex is appropriate and the autoupdate mechanism is justified.The regex
gcc-arm-none-eabi-(10\\.3-[\\d.]+)-win32.zipcorrectly limits version checks to the 10.3.x series. ARM publishes two arm-none-eabi 10.3 releases: 10.3-2021.07 and 10.3-2021.10, so the autoupdate mechanism serves a purpose and the restrictive scope aligns with the manifest's specific 10.3.x pinning.
Add the most widely used stable older version of
gcc-arm-none-eabi.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.