Skip to content

gcc-arm-none-eabi10.3: Add version 10.3-2021.10#2656

Open
JalonWong wants to merge 1 commit intoScoopInstaller:masterfrom
JalonWong:master
Open

gcc-arm-none-eabi10.3: Add version 10.3-2021.10#2656
JalonWong wants to merge 1 commit intoScoopInstaller:masterfrom
JalonWong:master

Conversation

@JalonWong
Copy link
Contributor

@JalonWong JalonWong commented Dec 25, 2025

Add the most widely used stable older version of gcc-arm-none-eabi.

Summary by CodeRabbit

  • New Features
    • Added GNU Arm Embedded Toolchain (v10.3-2021.10) as an installable option.
    • Added automatic update checking for new releases and built-in download integrity verification.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 25, 2025

Walkthrough

Adds a new manifest file bucket/gcc-arm-none-eabi10.3.json describing GNU Arm Embedded Toolchain v10.3-2021.10 with metadata, download URL and hash, extraction/bin paths, a regex-based checkver, and an autoupdate block.

Changes

Cohort / File(s) Summary
ARM Toolchain Manifest
bucket/gcc-arm-none-eabi10.3.json
New manifest for GNU Arm Embedded Toolchain v10.3-2021.10: metadata (description, homepage, license), versioned download URL and md5, extraction path and bin exposure, checkver regex for updates, and autoupdate block to construct new release URLs and retrieve hashes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I found a toolchain, shiny and neat,
Version ten-point-three, a developer treat.
Manifests penned with checksums in line,
Updates sniffed out by regex fine.
Hooray — compile dreams hop into time!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It acknowledges reading the Contributing Guide but lacks the required conventional PR title format and does not reference any related issue. Add a closing/relating issue reference (Closes #XXXX or Relates to #XXXX) and ensure the PR title follows the conventional format: gcc-arm-none-eabi10.3: Add version 10.3-2021.10 (manifest-name[@Version]: summary).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a new manifest file for gcc-arm-none-eabi version 10.3-2021.10.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

gcc-arm-none-eabi10

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0580c1e and fb477ea.

📒 Files selected for processing (1)
  • bucket/gcc-arm-none-eabi10.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (1)
bucket/gcc-arm-none-eabi10.json (1)

6-6: Verify the download URL is accessible and confirm 32-bit-only support is intentional.

The manifest hardcodes the download URL to the 32-bit (win32) Windows variant only. Clarify whether:

  • The 64-bit (win64) variant is intentionally omitted
  • Users needing 64-bit support should use a different manifest
  • ARM provides both variants for this version

If 64-bit support is needed, the manifest may need additional configuration or a separate manifest for the x64 variant.

@JalonWong JalonWong changed the title gcc-arm-none-eabi10: Add version 10.3-2021.10 gcc-arm-none-eabi10.3: Add version 10.3-2021.10 Dec 25, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (2)
bucket/gcc-arm-none-eabi10.3.json (2)

6-9: LGTM: Download and extraction configuration is correct.

The download URL, extraction directory, and binary path exposure are properly configured for this ARM GCC toolchain version.

Note: The MD5 hash issue on line 7 has already been flagged in previous reviews.


14-21: Autoupdate hash-finding issue already flagged.

The broken hash-finding regex on line 19 has been thoroughly documented in previous reviews. Additionally, when this is fixed, ensure the regex extracts SHA256 hashes rather than MD5 to align with the security improvements suggested for line 7.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb477ea and 847db75.

📒 Files selected for processing (1)
  • bucket/gcc-arm-none-eabi10.3.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/gcc-arm-none-eabi10.3.json (3)

1-2: LGTM: Version declaration is correct.

The version "10.3-2021.10" matches the ARM GNU Toolchain release format for this specific stable release.


1-22: Overall manifest structure is sound; address flagged issues before merging.

The Scoop manifest follows proper conventions and appropriately targets the specific 10.3-2021.10 release. The critical issues to address before merging are:

  1. Security: Update from MD5 to SHA256 hash (line 7, already flagged)
  2. Autoupdate: Fix the broken hash-finding regex (lines 19, already flagged)
  3. License: Verify the SPDX identifier is correct (line 5, new check requested)

The checkver regex (lines 10-13) is actually appropriate for this version-specific manifest, contrary to a previous review comment.


10-13: The checkver regex is appropriate and the autoupdate mechanism is justified.

The regex gcc-arm-none-eabi-(10\\.3-[\\d.]+)-win32.zip correctly limits version checks to the 10.3.x series. ARM publishes two arm-none-eabi 10.3 releases: 10.3-2021.07 and 10.3-2021.10, so the autoupdate mechanism serves a purpose and the restrictive scope aligns with the manifest's specific 10.3.x pinning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant