winbox-v3: Add version 3.43#2732
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughAdds a new Scoop manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with winbox-v3
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@bucket/winbox-v3.json`:
- Line 26: The 32-bit package currently exposes the executable as "winbox.exe"
in the "bin" field causing inconsistent CLI name vs the 64-bit config which
aliases "winbox64.exe" → "winbox"; update the 32-bit entry so the "bin" value
uses the canonical name "winbox" (or add an alias mapping from "winbox" to
"winbox.exe") so users can invoke "winbox" on both architectures—modify the
"bin" field that currently reads "winbox.exe" in the winbox-v3.json snippet to
the canonical "winbox" (or add an explicit alias mapping) to ensure parity with
the 64-bit config.
- Around line 35-38: The current checkver entry ("checkver" with regex "WinBox
([\\d.]+)<") targets a Livewire-rendered page so the regex will never match;
change the checkver to use a static/versioned source (for example a GitHub
releases RSS/JSON, an official API endpoint, or a direct file listing page)
instead of https://mikrotik.com/download, and update the "url" and matching
strategy accordingly (e.g., switch to a JSON/regexp on the releases feed or
point to a static HTML page that contains the version string). Locate the
"checkver" object in winbox-v3.json and replace the dynamic-page URL and regex
with the alternative source and an appropriate extractor (or use the
provider-specific releases endpoint) so the manifest can reliably extract the
WinBox version.
|
/verify |
|
All changes look good. Wait for review from human collaborators. winbox-v3
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. winbox-v3
|
Closes #2731
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit