n_m3u8dl-re: Add version 0.5.1-beta#2747
n_m3u8dl-re: Add version 0.5.1-beta#2747deuteros-gex wants to merge 2 commits intoScoopInstaller:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a new Windows package manager manifest for N_m3u8DL-RE (v0.5.1-beta) with metadata, architecture-specific download URLs and SHA-256 hashes, binary mappings, checkver regex, and autoupdate configuration. No code logic changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with n_m3u8dl-re
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/n_m3u8dl-re.json (1)
30-43: Consider using prerelease-aware release filtering instead of/releases/latestfor future stability.Line 31 uses GitHub's
releases/latest, which currently points tov0.5.1-beta(matching the manifest). However, this pattern is fragile: if the project ever releases a stable version without the-betasuffix,/latestwill diverge to that stable release, breaking the manifest'scheckver/autoupdate. To future-proof this manifest, use a prerelease-aware release source or pin to a specific release endpoint instead.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/n_m3u8dl-re.json` around lines 30 - 43, The manifest currently uses the GitHub /releases/latest URL inside the "checkver" block which can flip from prerelease to stable and break "autoupdate"; change "checkver" to query a prerelease-aware endpoint (e.g., GitHub Releases API list endpoint) or to the repository's releases page that you can filter for prereleases, update the "regex" to parse the returned tag (keep the existing pattern capturing the date as (?<date>\\d+)), and ensure "autoupdate" continues to use the matched variables (like $version and $matchDate) so the 64bit/32bit/arm64 "url" templates still resolve correctly; in short, replace the /releases/latest URL in "checkver" with a prerelease-aware source and keep the regex and autoupdate templates ($version, $matchDate) consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/n_m3u8dl-re.json`:
- Line 2: The manifest's "version" field currently pins a prerelease
("0.5.1-beta"); update the "version" value to a stable release (e.g., "0.5.1" or
the latest stable semver) to meet the acceptance criteria, or if prerelease
tracking is intentional, explicitly document that behavior (e.g., add a comment
or field indicating "prerelease-only") so it's clear this manifest intentionally
targets prereleases; locate and modify the "version" key in the manifest to make
this change.
---
Nitpick comments:
In `@bucket/n_m3u8dl-re.json`:
- Around line 30-43: The manifest currently uses the GitHub /releases/latest URL
inside the "checkver" block which can flip from prerelease to stable and break
"autoupdate"; change "checkver" to query a prerelease-aware endpoint (e.g.,
GitHub Releases API list endpoint) or to the repository's releases page that you
can filter for prereleases, update the "regex" to parse the returned tag (keep
the existing pattern capturing the date as (?<date>\\d+)), and ensure
"autoupdate" continues to use the matched variables (like $version and
$matchDate) so the 64bit/32bit/arm64 "url" templates still resolve correctly; in
short, replace the /releases/latest URL in "checkver" with a prerelease-aware
source and keep the regex and autoupdate templates ($version, $matchDate)
consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 21ec0430-36a3-4707-ba91-d4a8e984878d
📒 Files selected for processing (1)
bucket/n_m3u8dl-re.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with n_m3u8dl-re
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. n_m3u8dl-re
|
1 participant
Closes ScoopInstaller/Main#6704
The english documentation
https://github.com/nilaoda/N_m3u8DL-RE/blob/main/README.en.md
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit