groovy-classic: add manifest for legacy groovy (version <= 2.4.3)#2873
groovy-classic: add manifest for legacy groovy (version <= 2.4.3)#2873chaerun wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughAdds a new Scoop package manifest for Groovy Classic v2.4.3 defining metadata, suggested dependencies, Artifactory ZIP download with SHA256, extraction and GROOVY_HOME setup, Windows ChangesGroovy Classic Package Manifest
🎯 2 (Simple) | ⏱️ ~5 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/groovy-classic.json`:
- Around line 26-36: Narrow the checkver.regex so it only discovers 2.4.x
releases up to 2.4.3 (preventing matching newer 2.5/3.x/4.x archives); update
the "checkver" entry (checkver.regex) to something like
groovy-binary-(2\.4\.(?:0|1|2|3))\.zip so discovered $version stays within the
classic 2.4.3 series while leaving "autoupdate.url" and "extract_dir" unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d3f64d75-c9b9-4e65-9808-fecb7b68044c
📒 Files selected for processing (1)
bucket/groovy-classic.json
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/groovy-classic.json`:
- Line 28: The checkver.regex currently has no capture group so Scoop cannot
populate $version; update the "regex" value in groovy-classic.json to include a
capturing group (either group 1 or a named group "version") around the version
portion (e.g., capture the digits in the filename) so checkver can extract the
version used by autoupdate.url and extract_dir; modify the pattern that
currently is "groovy-binary-2\.4\.3\.zip" to a pattern with a capture like
"groovy-binary-(\d+\.\d+\.\d+)\.zip" or use a named group
"(?<version>\d+\.\d+\.\d+)".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cae99339-b342-4465-a2d7-035c6c93c436
📒 Files selected for processing (1)
bucket/groovy-classic.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with groovy-classic
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. groovy-classic
|
|
Hi @z-Fng, |
1 participant
Legacy 'Groovy Classic' binaries. This manifest provides older distributions of the Groovy programming language released up until version 2.4.3 (March 2015), before the transition to the Apache Software Foundation.
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit