fix: install cleanup - missing Flask dep and CLI alignment#133
Closed
whitebrendan wants to merge 1 commit intoScottcjn:mainfrom
Closed
fix: install cleanup - missing Flask dep and CLI alignment#133whitebrendan wants to merge 1 commit intoScottcjn:mainfrom
whitebrendan wants to merge 1 commit intoScottcjn:mainfrom
Conversation
5 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to beacon-skill! Thanks for your first pull request.
Quick checklist:
- Tests pass (
pytest tests/) - New code includes SPDX license header
- Focused on a single change
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100)
A maintainer will review your PR soon!
Owner
|
Closing — #130 merged for the core fix. Your additional webhook flags (--bounty-url, --reward-rtc, --field) are interesting — consider submitting those as a separate feature PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #125 / Bounty #1491.
Changes:
flaskfrom optionalconwaydependencies to coredependenciesinpyproject.tomlto ensurebeacon webhook serveworks out-of-the-box.beacon webhook sendCLI to support--text,--link,--bounty-url, and other flags, aligning it with the examples in README.md and other transports like UDP.tests/smoke_test.pyto verify basic CLI functionality.Verified in a fresh environment.
Wallet: whitebrendan (miner_id)