More improvements to MapMatchFilter and intersection callout after user testing#509
Merged
Merged
Conversation
This means that all intersection callouts start from the furthest Way to the left. That's less surprising than the previously random order.
Issue Scottish-Tech-Army#506 had missing intersection callouts which was due to a miscalculation of the angle between two headings. It should have been calculating the angle between the lines assuming them to be bidirectional rather than just the headings. The MapMatchFilter has been tweaked to better deal with short spells where a route is deviated from.
Without this, we were picking some of these intersections to announce, and then dropping them when it came to announce them. This prevented other more useful intersections being announced.
More care was required to ensure that the START and END intersections were indeed at the START and END of the geometry.
Figuring out which direction a line is travelling on across a tile boundary was being done incompletely. The new changes fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.