Comment out unused resource strings#512
Merged
Merged
Conversation
The commentOutResourceString.sh and uncommentOutResourceString.sh scripts take a single argument which is the resource name e.g. general_alert_yes. This is commented/uncommented out in all strings.xml files that are contained within "values" sub-directories. The unusedResources.sh parses a file named unused_resources.txt and comments out all of the files listed in that file - one filename per line. This was used to comment out all of the resources returned by the Android Studio "Unused resources" code analysis.
In preparation for pushing strings to Weblate for translation, comment out all of the strings resources that we don't currently use. This also helps see in which areas the Android app differs from the iOS app in terms of string usage.
davecraig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking at pushing our resources to Weblate for translation, so remove all those strings which are not actually used. They are left in the code, just commented out which makes it easy to see where the Android app differs from the iOS app.