Gadgil48/175 new core data structures #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 28, 2020 12:09
…tegration into current IO module code.
…few bugs still need fixing.
…ember added to HealthBoardData class).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a working solution to ScottishCovidResponse/SCRCIssueTracking#175. There's now a
HealthBoardDataclass that pre-selects observation according to theherd_idprovided in theparameters.inifile. This is only initialized in the I/O module(twice once for inference framework and once for the model config) and after thatshb_id,herd_idorregion_iddon't need to be passed around between the inference framework and the selected model.There are also two new enumerated types introduced, one for selecting the age group and another for selecting case fatality ratio categories.
I'm not sure I'm seeing the value now that it's complete, but hopefully a different pair of eyes can see the advantages.