fix(keycloak-scoutid): add notification-sender client role - #38
Merged
Conversation
The j26-notifications client was missing its `notification-sender` client role, so it couldn't be assigned via resource_access. Regenerated 45-keycloak-config-configmap.yaml from the j26-keycloak-scoutid source (04-clients.yaml) to add it under roles.client.j26-notifications. Additive only — no other realm changes. Already applied + verified live in the prod jamboree26 realm (config-cli import clean, role present on the client). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a missing Keycloak client role (notification-sender) to the j26-notifications client in the production j26-keycloak-scoutid realm configuration, enabling assignment via resource_access["j26-notifications"].roles.
Changes:
- Adds
roles.client.j26-notifications.notification-senderwith a description to the prod realm config ConfigMap.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
scriptcoded
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing
notification-senderclient role to thej26-notificationsclient in the prodjamboree26realm config.Why
j26-notificationshad no client roles defined, sonotification-sendercouldn't be assigned to users viaresource_access["j26-notifications"].roles. This adds it.Scope
45-keycloak-config-configmap.yamlin the prod manifest dir from thej26-keycloak-scoutidsource (keycloak-config/04-clients.yaml, committed/pushed there separately).Already verified live
Applied to the prod cluster and ran config-cli ahead of this PR — import clean (no ERROR lines), and the role is confirmed present on the
j26-notificationsclient viakcadm. So merging makesmainmatch what's already running.🤖 Generated with Claude Code