Skip to content

feat(prod): disable keycloak config-cli + bump image to dev's build - #83

Merged
hakan-persson merged 1 commit into
mainfrom
disable-configcli-bump-keycloak
Jul 24, 2026
Merged

feat(prod): disable keycloak config-cli + bump image to dev's build#83
hakan-persson merged 1 commit into
mainfrom
disable-configcli-bump-keycloak

Conversation

@hakan-persson

Copy link
Copy Markdown
Member

Two coupled changes for the GUI-managed prod Keycloak.

1. Permanently disable config-cli

Removes 40-config-cli.yaml + 45-keycloak-config-configmap.yaml from the kustomization so the declarative config import never runs again. Prod Keycloak is GUI-managed (team decision 2026-07-22) — a config-cli re-run would overwrite admin-console edits. Both files stay in the repo (dormant) so declarative management can be restored if we ever revert.

This is the durable, git-based version of the 2026-07-22 cluster-level auto-sync suspend (which didn't persist). After this merges, the "don't manually sync j26-keycloak-scoutid-prod" caveat goes away — there's no config-cli hook left to fire.

2. Bump the Keycloak image to dev's tested build

scoutid-keycloak:sha-b08ab09 (2026-06-17) → sha-e2b6218 (2026-07-22) — the image dev runs and has been tested on. Verified pullable.

Why they're in one PR

With config-cli gone from the manifest, ArgoCD can sync this normally: the new image rolls without triggering a config import, so GUI edits survive. Doing the image bump alone (with config-cli still present) would re-run the import on sync.

On merge

  • ArgoCD auto-syncs → keycloak Deployment rolls to the new image; config-cli does not run.
  • prune: true deletes the now-undeclared keycloak-config ConfigMap from j26-prod (harmless — nothing consumes it once the Job is gone).

Renders clean (no config-cli Job/ConfigMap in output), server-side --dry-run passes.

🤖 Generated with Claude Code

Two coupled changes for the GUI-managed prod Keycloak:

- Remove 40-config-cli.yaml + 45-keycloak-config-configmap.yaml from the
  kustomization so the declarative config import never runs again. Prod
  Keycloak is GUI-managed (team decision 2026-07-22); a config-cli re-run
  would overwrite admin-console edits. Both files stay in the repo (dormant)
  so declarative management can be restored if needed.
- Bump the Keycloak image sha-b08ab09 (2026-06-17) -> sha-e2b6218
  (2026-07-22), matching what dev runs and has been tested on.

With config-cli gone from the manifest, ArgoCD can sync this normally: the
new image rolls without triggering a config import, so GUI edits survive.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 24, 2026 16:47
@hakan-persson
hakan-persson requested a review from a team as a code owner July 24, 2026 16:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the production Keycloak config import Job (config-cli) to prevent ArgoCD syncs from overwriting GUI-managed configuration, and bumps the prod Keycloak image to the dev-tested build.

Changes:

  • Remove 40-config-cli.yaml and 45-keycloak-config-configmap.yaml from the prod Keycloak kustomization resources.
  • Update the prod Keycloak Deployment image from sha-b08ab09 to sha-e2b6218.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
k8s/app-manifest-prod/j26-keycloak-scoutid/kustomization.yaml Stops deploying config-cli (and its ConfigMap) and documents the rationale for GUI-managed prod Keycloak.
k8s/app-manifest-prod/j26-keycloak-scoutid/20-keycloak.yaml Bumps the prod Keycloak container image to the dev-tested SHA.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread k8s/app-manifest-prod/j26-keycloak-scoutid/kustomization.yaml
@hakan-persson
hakan-persson merged commit f38be25 into main Jul 24, 2026
2 checks passed
@hakan-persson
hakan-persson deleted the disable-configcli-bump-keycloak branch July 24, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants