fix(monitoring): use $VAR syntax for Azure Monitor client secret - #91
Merged
Conversation
$__env{AZURE_CLIENT_SECRET} registered the datasource but never
actually resolved the secret (Grafana health check kept returning
"clientSecret must be set" even though the env var was confirmed
present in the container on a fresh pod boot). Switching to the
plain $VARNAME interpolation form fixed it — verified live via
the datasource health check (Azure Monitor + Resource Graph both
connect successfully now).
There was a problem hiding this comment.
Pull request overview
Updates the monitoring stack’s Grafana provisioning values to ensure the Azure Monitor datasource can resolve its client secret from the Grafana container environment at runtime, restoring datasource health checks for Azure Monitor / Resource Graph.
Changes:
- Switch Azure Monitor datasource
secureJsonData.clientSecretinterpolation from$__env{AZURE_CLIENT_SECRET}to$AZURE_CLIENT_SECRETin Grafana Helm values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error getting credentials: unable to instantiate credentials, clientSecret must be set.$__env{AZURE_CLIENT_SECRET}interpolation insecureJsonDatanever resolved, even though the env var was confirmed present in the Grafana container on a fresh pod boot (checked viakubectl exec ... env). Switching to the plain$AZURE_CLIENT_SECRETform (Grafana's other documented env-interpolation syntax) fixed it immediately.Test plan
🤖 Generated with Claude Code