Add find_linked_recursive method to ModelTrait #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necessary joins in ModelTrait
tyt2y3
reviewed
Feb 22, 2025
Comment on lines
209
to
-249
| "SELECT `fruit`.`id`, `fruit`.`name`, `fruit`.`cake_id` FROM `fruit`", | ||
| "INNER JOIN `cake` ON `cake`.`id` = `fruit`.`cake_id`", | ||
| "WHERE `cake`.`id` = 12", |
There was a problem hiding this comment.
Oh wow this is such a smart optimization
tyt2y3
reviewed
Feb 22, 2025
Comment on lines
+49
to
+50
| .on_condition(|_cake_filling, cake| { | ||
| Expr::col((cake, super::cake::Column::Name)) |
There was a problem hiding this comment.
why is the left and right swapped?
I understand your point that this is a bug, but this will be a breaking change to fix this at this point, sadly. Can you add some test cases to demonstrate the recursive use cases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
Linked<From = M, To = M>exists, thenmodel.find_linked_recursivewill generate a CTE to follow the links recursively and return all ancestors or descendants of the model.Bug Fixes
RelationDef.rev()did not swap the arguments to itson_conditionChanges
#[ignore]tojoin_16andjoin_18tests insrc/query/join.rsbecause the generated queries make no sense, I suggest removing them (andentity_linked::JoinWithoutReverse)