Allow to specify an escape character in like and not_like
#2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures seem unrelated to my change: cannot find type `IpNetwork` in this scope |
Expurple
force-pushed
the
accept-into-like-expr
branch
from
7a9710b to
4d4a2c3
Compare
|
Rebased to pick up the CI fix and trigger a re-run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
Bug Fixes
Breaking Changes
Changes
likeandnot_like.The old signatures were insufficiently generic and didn't accept
LikeExpr. See the linked discussion.Changing the parameter type from
T: Into<String>toT: IntoLikeExpris a backwards-compatible, because the former is already generic and is a subtype of the latter (IntoLikeExpris implemented forT: Into<String>).It's also consistent with the corresponding
ExprTraitmethods.