Select up to 10

[billy1624]

PR Info

• Closes SelectThree up to SelectNine #21
• Related
  • Select three #2518
  • Can SelectThree be extended to implement SelectNine through macros? #2525

New Features

• Select up to 10

[Copilot]

Pull Request Overview

This PR introduces the “Select up to 10” feature by refactoring and expanding the existing selection types. Key changes include:

• Defining a macro (def_select_struct!) to reduce repetitive struct definitions for selections from two up to ten models.
• Replacing individual trait implementations with macros (impl_query_trait!, impl_selector_trait!, etc.) across multiple modules.
• Updating join, combine, executor, paginator, and cursor modules to support selection operations on up to ten entities.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/query/select.rs	Refactored select struct definitions and trait implementations using macros.
src/query/mod.rs	Updated re-exports in the combine module to include new selection types.
src/query/join.rs	Modified related join implementations to use a new macro with updated documentation.
src/query/combine.rs	Replaced individual impls with macros for selecting additional entity columns.
src/executor/select.rs	Introduced macros for model conversion and JSON conversion supporting new selection types.
src/executor/paginator.rs	Updated paginator trait implementations via macros to support up to ten models.
src/executor/cursor.rs	Refactored cursor trait implementations using macros with adjustments for multi-entity support.

Comments suppressed due to low confidence (2)

src/query/join.rs:165

• [nitpick] The doc comments for find_also_related (and its counterpart) use terms like 'second last' and 'last' which may be ambiguous. Consider clarifying these descriptions to more explicitly indicate which related entity is being joined.

pub fn find_also_related<R>(self, r: R) -> crate::$next_struct<$($generics),*, R>

src/query/combine.rs:119

• Using placeholders ('_') for type parameters in the prepare_select_col call might reduce clarity and could potentially lead to type inference issues. Consider providing explicit type parameters to ensure clearer code maintainability.

prepare_select_col::<$last, _, _>(&mut self, $col_prefix);

[Copilot]

The macro calls default() on the entity type parameter without an explicit Default bound. Ensure that all entity types passed to this macro implement Default to avoid potential runtime issues.

[guymave]

yesssssss

[edmiester777]

Let's get it! Should this be draft though?