Implement IntoSimpleExpr for FunctionCall #2822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huliiiiii
approved these changes
Nov 28, 2025
Expurple
reviewed
Dec 3, 2025
Member
Expurple
left a comment
Expurple
left a comment
There was a problem hiding this comment.
If I remember correctly, now we have a blanket impl IntoSimpleExpr for T: Into<SimpleExpr> to make IntoSimpleExpr interchangable with Into<SimpleExpr>. To get that benefit, your new impl should be worded as impl From<FunctionCall> for SimpleExpr.
Good change otherwise! Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
No issue, but see question "FunctionCall and IntoSimpleExpr" in the discord.
New Features
Bug Fixes
allows you to do
sea_orm::query::helper::QueryOrder::order_by_ascwith an argument ofFunctionCalldirectly, without having to wrap it inExpr::Functioncallexample patch i can apply to my project due to this patch:
Ok(locations::Entity::find() .filter(locations::Column::Userid.eq(userid)) .filter(dist.clone().lt(5000)) - .order_by_asc(Expr::FunctionCall(dist)) + .order_by_asc(dist) .all(tx) .await?)Breaking Changes
Changes