fix: allow LEFT JOIN to produce None for nested models #2845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Bug Fixes
When using LEFT JOIN with a nested
Option<Model>, code tried to read the missingrelated row as if it were always present. This caused a type error instead of simply
returning
None.This change makes nested optional models behave normal by treating
all-null fields as a missing record.
Testing
Added test that validates the fix.