feat: Add CockroachDB support #2930
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added DatabaseBackend::Cockroach variant - Added cockroachdb feature flag - Added schema generation for IDENTITY columns - Added documentation and tests Related: SeaQL/sea-query#329
- Fix non-exhaustive pattern matching in statement.rs for CockroachDB variant - Add cockroachdb feature to test macro cfg attributes - Add CockroachDB to tracing spans db_system_name - Add CockroachDB to paginator i64 count handling - Add CockroachDB to proxy database connector - Add CockroachDB to schema discovery - Expand test coverage with 5 new tests: * Statement building test * Schema statements test * Mock database test * INSERT building test Co-Authored-By: Claude <[email protected]>
The option-cockroachdb-use-identity feature was defined but never used. CockroachDB already requires GENERATED BY DEFAULT AS IDENTITY columns, which is the default behavior of PostgresQueryBuilder when option-postgres-use-serial is not enabled. Cleanup: removed from both sea-query and sea-orm Cargo.toml files. Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds CockroachDB support to SeaORM. CockroachDB is wire-compatible with PostgreSQL, so most functionality works with the existing sqlx-postgres driver.
Changes
cockroachdbfeature flagDatabaseBackend::Cockroachvariantcockroachdb://,postgres://,postgresql://)Feature Flags
cockroachdbcockroachdb-use-identity-pkTesting
Added
tests/cockroachdb_tests.rswith tests for:Breaking Changes
None - all changes are gated behind the new
cockroachdbfeature flag.Related: #2929