Package and city marker clean-up #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the code style to match the rest of the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #35.
I implemented a primitive system that destroys the previous package and city marker when a new package is dropped to prevent more and more GameObjects from building up over time (my poor memory!).
I moved the
packageDroppedevent from the player into the quest system since it was unused anyway, and also the quest system is responsible for package dropping, not the player.If this causes merge conflicts, you could discard the change I made to the
Game.unityscene since you just have to attach thePackageCleanupcomponent to theQuest SystemGameObject for the clean-up system to work.A possible extra detail/improvement could be old packages and city markers fading out before getting destroyed.