Major refactoring of sorting structures. #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts not touched, broken.
Unit tests fixes - problems were only on the automatically converted unit tests, no in the refactored logic. A good sign.
…tures # Conflicts: # manifest.json # src/custom-sort/matchers.ts # src/test/unit/sorting-spec-processor.spec.ts
…efactoring-regroup-sorting-structures # Conflicts: # manifest.json # src/test/unit/sorting-spec-processor.spec.ts
…efactoring-regroup-sorting-structures
Base automatically changed from
171-poc-metadata-value-extractors-idea
to
master
January 3, 2025 19:10
SebastianMC
deleted the
nov-2024-refactoring-regroup-sorting-structures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A massive refactoring done on top of #172 which caused the structures to become overloaded, thus requiring cleanup