Reenable binary sensors #737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates entities for Wyze Sense motion and contact sensors as well as camera motion detection. These both used to use the SensorService.process_update to update themselves, which just hammered the Wyze api in a tight loop (which understandably made Wyze angry). For the Wyze Sense contact and motion sensors, this change instead uses UpdateManager to only poll every 30 seconds. The sensors are also disabled by default, which should further reduce traffic to the Wyze API. For the camera motion sensor, it registers for the update events, which shouldn't produce any additional load given that the system is already polling for camera updates.
Collaborator
|
I believe these were disabled intentionally because we were spamming the Wyze servers. Have to check with @SecKatie on re-enabling. |
Contributor
Author
|
@brg468 correct, they were. This at least attempts to implement it in a way that reduces that spam. See the description for details. It may not be enough to make merging this appropriate, I can't be the judge of that. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Please deliver this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates entities for Wyze Sense motion and contact sensors as well as camera motion detection.
These both used to use the SensorService.process_update to update themselves, which just hammered the Wyze api in a tight loop (which understandably made Wyze angry).
For the Wyze Sense contact and motion sensors, this change instead uses UpdateManager to only poll every 30 seconds. The sensors are also disabled by default, which should further reduce traffic to the Wyze API.
For the camera motion sensor, it registers for the update events, which shouldn't produce any additional load given that the system is already polling for camera updates.