Update Downloader.cs #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand Message-ID Regex to include pipes and double quotes. This was to address an bug where message IDs had a pipe char in, Downloader then failed when trying to create a file with a pipe in the name. I think the ideal approach would be similar to the "illegalChars" one or one based around encoding URL-style, but I couldn't get that to work quickly and this solved the immediate problem. Not sure if the double quote is of practical value but included for completeness.
|
I very much appreciate the tool and it was extremely useful to me. Thank you! Sorry for any bad Github/code etiquette on my part, this is my first time using Github for anything other than support, text and downloads. And I'm not a C# programmer. But these changes enabled me to finish downloading the last mailbox I needed, so may come in handy for someone else. |
bastianonm
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand Message-ID Regex to include pipes and double quotes. This was to address a bug where message IDs had a pipe char in, Downloader then failed when trying to create a file with a pipe in the name. I think the ideal approach would be similar to the "illegalChars" one or one based around encoding URL-style, but I couldn't get that to work quickly and this solved the immediate problem. Not sure if the double quote is of practical value but included for completeness.