fix: Implement Secure Payment Gateway and Payment Service#14
Closed
Mira-Mjodheim wants to merge 1 commit into
Closed
fix: Implement Secure Payment Gateway and Payment Service#14Mira-Mjodheim wants to merge 1 commit into
Mira-Mjodheim wants to merge 1 commit into
Conversation
FIXED
Three changes made:
**`paymentService.js`**
- Added an early guard in `getStripe()`: throws `"STRIPE_SECRET_KEY is not configured"` instead of silently constructing `Stripe("")` and failing op
Author
|
Closing — I'm not able to verify this bounty is legitimate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
FIXED
Three changes made:
paymentService.jsgetStripe(): throws"STRIPE_SECRET_KEY is not configured"instead of silently constructingStripe("")and failing opaquely at call-time.try/catchwrapper that caught and immediately re-threw — dead code that obscured the intent.paymentController.jsfail(res, error.message, error.statusCode ?? 400)— forwards the Stripe HTTP status code when present. Card errors (StripeCardError) carrystatusCode: 402, rate limits429, auth failures401, connection errors502. CollapsChanged Files
apps/api/package.jsonapps/api/src/controllers/paymentController.jsapps/api/src/services/paymentService.jspackage-lock.json