Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"scripts": {
"dev": "node src/server.js",
"start": "node src/server.js",
"test": "node --test src/tests"
"test": "node --test src/tests/*.test.js"
},
"dependencies": {
"cors": "^2.8.5",
Expand Down
11 changes: 11 additions & 0 deletions apps/api/src/middleware/rateLimit.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,14 @@ export const apiLimiter = rateLimit({
standardHeaders: "draft-7",
legacyHeaders: false
});

export const authLimiter = rateLimit({
windowMs: 15 * 60 * 1000,
limit: 10,
standardHeaders: "draft-7",
legacyHeaders: false,
message: {
success: false,
message: "Too many authentication attempts, try again later"
}
});
3 changes: 3 additions & 0 deletions apps/api/src/routes/authRoutes.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import { Router } from "express";
import { login, oauthCallback, refresh, register } from "../controllers/authController.js";
import { authLimiter } from "../middleware/rateLimit.js";

export const authRoutes = Router();

authRoutes.use(["/register", "/login", "/refresh"], authLimiter);

authRoutes.post("/register", register);
authRoutes.post("/login", login);
authRoutes.get("/oauth/:provider/callback", oauthCallback);
Expand Down
64 changes: 64 additions & 0 deletions apps/api/src/tests/authRateLimit.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
import test from "node:test";
import assert from "node:assert/strict";
import { createApp } from "../app.js";

async function withServer(run) {
const app = createApp();
const server = app.listen(0);

await new Promise((resolve, reject) => {
server.once("listening", resolve);
server.once("error", reject);
});

try {
const { port } = server.address();
return await run(`http://127.0.0.1:${port}`);
} finally {
await new Promise((resolve, reject) => {
server.close((error) => (error ? reject(error) : resolve()));
});
}
}

test("auth endpoints enforce a stricter credential-attempt rate limit", async () => {
await withServer(async (baseUrl) => {
const body = JSON.stringify({
email: "client@example.com",
password: "correct-horse-battery"
});

for (let attempt = 0; attempt < 10; attempt += 1) {
const response = await fetch(`${baseUrl}/api/auth/login`, {
method: "POST",
headers: { "Content-Type": "application/json" },
body
});

assert.equal(response.status, 200);
}

const limitedResponse = await fetch(`${baseUrl}/api/auth/login`, {
method: "POST",
headers: { "Content-Type": "application/json" },
body
});
const payload = await limitedResponse.json();

assert.equal(limitedResponse.status, 429);
assert.deepEqual(payload, {
success: false,
message: "Too many authentication attempts, try again later"
});
});
});

test("non-auth API routes remain on the general limiter", async () => {
await withServer(async (baseUrl) => {
const response = await fetch(`${baseUrl}/health`);
const payload = await response.json();

assert.equal(response.status, 200);
assert.deepEqual(payload, { ok: true, service: "api" });
});
});
Loading