Fix: update API test script to target files and add regression check (Fixes #4111)#4112
Open
mvmax-dev wants to merge 1 commit into
Open
Fix: update API test script to target files and add regression check (Fixes #4111)#4112mvmax-dev wants to merge 1 commit into
mvmax-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #4111.
Problem
The API package test script in
apps/api/package.jsonwas configured to runnode --test src/tests. Because it targeted the directory instead of files, the Node.js test runner failed withMODULE_NOT_FOUNDerror when trying to resolveapps/api/src/tests.Solution
testscript insideapps/api/package.jsonto target concrete test files:node --test src/tests/*.test.js.apps/api/src/tests/package.test.jsthat readspackage.jsonand asserts that thetestscript targets the files correctly and doesn't fall back to targeting the directory.All tests passed successfully:
Closes #4111