Skip to content

Fix notification server-owned fields#4185

Open
yZangEren wants to merge 2 commits into
SecureBananaLabs:mainfrom
yZangEren:fix-notification-server-owned-state
Open

Fix notification server-owned fields#4185
yZangEren wants to merge 2 commits into
SecureBananaLabs:mainfrom
yZangEren:fix-notification-server-owned-state

Conversation

@yZangEren

@yZangEren yZangEren commented Jun 4, 2026

Copy link
Copy Markdown

Summary

  • Keep notification id and read state server-owned during creation
  • Preserve caller-supplied notification content while preventing id and read overrides
  • Add focused API coverage for attempted override and persisted notification state

Tests

  • node --test src\tests\notification.test.js src\tests\health.test.js
  • git diff --check

Closes #4182
Refs #743

/claim #743

Demo

github-actions Bot added a commit that referenced this pull request Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification creation should preserve server-owned id and unread state

1 participant