fix(ui): expose importable JavaScript entrypoint for @freelanceflow/ui#4271
Closed
RanuK12 wants to merge 1 commit into
Closed
fix(ui): expose importable JavaScript entrypoint for @freelanceflow/ui#4271RanuK12 wants to merge 1 commit into
RanuK12 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@freelanceflow/uiso workspace consumers can import the package at runtime.packages/ui/package.json:main→dist/index.js, addtypes,exports,buildscript, andpeerDependencies.packages/ui/tsconfig.jsonwith JSX support for compiling React components.ButtonandCard.Problem
@freelanceflow/uideclaredmainassrc/index.ts, a TypeScript source file. Node.js cannot resolve TypeScript directly, soimport("@freelanceflow/ui")fails at runtime. The component modules (Button,Card) were not reachable as JavaScript.Fix
Following the same pattern that was applied to
@freelanceflow/db(#2775), this PR:tsconfig.jsontargeting ES2020/CommonJS withjsx: "react"for TSX compilation.package.jsonwith propermain,types, andexportsfields pointing todist/.buildscript (tsc) and TypeScript dev dependency.reactas a peer dependency (required by the components).Validation
node --test packages/ui/test/ui-entrypoint.test.js— 4/4 passnode --test apps/api/src/tests/*.test.js— 1/1 pass (no regressions)node -e "import(./packages/ui/dist/index.js).then(m => console.log(Object.keys(m)))"→["Button", "Card"]/claim #743
Closes #4168