Require admin role for metrics#4279
Open
laughlife wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #743
Summary
role: "admin"before serving/api/admin/metrics.403 Forbiddenwhile admin tokens still receive the metrics payload.*.test.jsfiles explicitly so the standard workspace test command works in the current Node runner.Verification
node --test apps/api/src/tests/admin.test.jsfailed because aclienttoken received200instead of403.npm run test -w apps/apipasses.git diff --checkpasses.Demo
The automated tests exercise the protected endpoint end to end by starting the Express app, calling
/api/admin/metricswith client and admin JWTs, and asserting the expected HTTP responses.