feat: integrate Stripe SDK for real PaymentIntent creation (closes #1)#71
Open
qiqi1616 wants to merge 2 commits into
Open
feat: integrate Stripe SDK for real PaymentIntent creation (closes #1)#71qiqi1616 wants to merge 2 commits into
qiqi1616 wants to merge 2 commits into
Conversation
Code ReviewPR: feat: integrate Stripe SDK for real PaymentIntent creation (closes #1) by @qiqi1616
Wallet: Code review for SecureBananaLabs bug-bounty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1
Summary
pay_${Date.now()}payment stub with real Stripe PaymentIntent creation through the Stripe Node SDKamountas a positive integer, defaults/lowercasescurrency, and supports optional metadatapaymentIdandclientSecretfrom the real Stripe response while preserving Stripe error messagesstripe ^17.0.0dependency toapps/api/package.jsoninitStripe()for testabilityVerification
stripe.paymentIntents.create()STRIPE_SECRET_KEYenv var