feat: implement secure payment gateway with Stripe SDK#72
Open
dreamer0129 wants to merge 2 commits into
Open
Conversation
- Install stripe package - Replace stub with real Stripe PaymentIntent integration - Add amount validation (required, positive integer) - Add currency default to 'usd' - Add error handling for Stripe API errors - Add tests for payment service - Closes SecureBananaLabs#1 ($350 bounty)
Code ReviewPR: feat: implement secure payment gateway with Stripe SDK by @dreamer0129
Wallet: Code review for SecureBananaLabs bug-bounty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented the Secure Payment Gateway and Payment Service as described in issue #1.
Changes Made
Added Stripe SDK - Installed
stripepackage v16.0.0Implemented real createPaymentIntent - Replaced stub with actual Stripe integration:
amountis required and must be a positive integercurrencyto 'usd' if not providedSTRIPE_SECRET_KEYenv variable (no hardcoded keys)clientSecretandpaymentIdAdded tests - 8 test cases covering:
Checklist
stripenpm package installedSTRIPE_SECRET_KEYenvironment variable usedstripe.paymentIntents.create()call madeclientSecretandpaymentIdCloses #1