Vietnamese translation 1st PR #46
Conversation
add Vietnamese Translation update Readme file per @kdmukai
Fix the job failed due to a KeyError: 'độ dài' in the test tests/screenshot_generator/generator.py::test_generate_all[vi]. This error indicates that the string 'độ dài' is missing from the relevant translation dictionary or data structure used in the test for the Vietnamese locale.
Shorten phrases to fit small screen
Shorten and expand for artistic view and meaning
|
Please split this into two PRs: One for the README and one for the Vietnamese translations. The README PR will need a little more explanation; at first I didn't even remember that these instructions weren't in this repo yet. |
|
Note: These translations were NOT in transifex. I was able to upload them from this PR into Transifex. Please review the README steps and download the messages.po from transifex and replace the file in this PR with the transifex version. They should be more or less identical, but I just want to guarantee that everything remains fully consistent and in sync with transifex. |
|
I'm glad to see you incorporated the proposed fixes to Keith's Readme file. Like Keith said, if you can split the documentation update our to it's own PR, we can get that addressed on it's own. Now that Keith has backfilled your translations into Transifex, ideally we can identify someone else to serve in the Reviewer role to check what you have proposed there (both the strings, and ideally the screenshots). |
bitcoinprecept
added
documentation
|
The README.md file has been reverted to its original state. This branch now exclusively contains the newly added Vietnamese translation. The messages.po file used for this translation was downloaded directly from Transifex, as advised. |
Replace capital letters from message.po file downloaded from transifex with lower case in buttons. Already informed admin
3 participants
add Vietnamese Translation
update Readme file per @kdmukai